Skip to content

unspecialize float for all torch.compile callers #138918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 44 commits into from
Closed

unspecialize float for all torch.compile callers #138918

bobrenjc93 wants to merge 44 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Oct 25, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

@bobrenjc93
always unspecialize float
e8c1f86 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138918

Note: Links to docs will display an error until the docs builds have been completed.

❌ 54 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit b02c396 with merge base e6ff07f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@bobrenjc93
Update on "always unspecialize float"
490f888 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 25, 2024
@bobrenjc93
always unspecialize float
85f540d 
ghstack-source-id: 386ffb7
Pull Request resolved: #138918
@bobrenjc93 bobrenjc93 changed the title always unspecialize float unspecialize float for all torch.compile callers Oct 25, 2024
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 31, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@bobrenjc93
Update
8e5d2cc 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

Successfully rebased gh/bobrenjc93/89/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138918)

pytorchmergebot pushed a commit that referenced this pull request Oct 31, 2024
@bobrenjc93
always unspecialize float
9928119 
ghstack-source-id: cee4c34
Pull Request resolved: #138918
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
7a7690c 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
This was referenced Oct 31, 2024
Closed
Closed
Closed
bobrenjc93 added a commit that referenced this pull request Oct 31, 2024
@bobrenjc93
always unspecialize float
c9ae5b3 
ghstack-source-id: 47eae2d
Pull Request resolved: #138918
@bobrenjc93 bobrenjc93 mentioned this pull request Oct 31, 2024
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
f1771ed 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
1e799fd 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
0fc044f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
2fffe3e 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
This was referenced Nov 1, 2024
Closed
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
3f99ef8 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 1, 2024
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
6a8cb10 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
955c1ee 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
9f41709 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 3, 2024
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
2059a11 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
96f06b6 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
a4d1756 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
22a6709 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 4, 2024
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
66af461 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
c5ea1bc 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
16ba1e7 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
14b1e64 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
06c8275 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
312b4c7 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
4a7fbd7 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
4cefb23 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 6, 2024
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
c0c8880 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
This was referenced Nov 6, 2024
Closed
Closed
Closed
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
3b0de74 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
bb3599a 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
2e44a70 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
fb9eedd 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
ff09f30 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93
Update on "unspecialize float for all torch.compile callers"
b02c396 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 closed this Nov 14, 2024
@github-actions github-actions bot deleted the gh/bobrenjc93/89/head branch December 15, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ciflow/inductor module: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobrenjc93 @pytorchmergebot