[Pipelining] Relax multi-stage constraint #138862
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138862
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New FailuresAs of commit 7fe3330 with merge base failed to retrieve merge base, please contact dev infra: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
| f"Multi-stage schedule expects at least two stages but got {len(stages)}" | ||
| ) | ||
|
|
||
| # TODO(whc) can we just delete this assert? It is convenient to do a unit test with a single stage, and |
There was a problem hiding this comment.
It is convenient to do a unit test with a single stage
Let's say this can this be implemented, we are not replacing all tests with single stage, right?
There was a problem hiding this comment.
No, I just added one new test. In general I found it's worth making tests single process and as simple as possible to test the desired behavior even if I could just use a multiproc multistage test. But there are still e2e multiproc tests for all the schedules.
|
PR description? |
Stack from ghstack (oldest at bottom):
It is convenient to do a unit test with a single stage, and this
requirement seems unnecesary. Eventually we may want to consolidate
classes to only use one runtime class for single or multi-stage
schedules.