-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Eliminate c10::value_or_else #138818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate c10::value_or_else #138818
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138818
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2bddc94 with merge base e7f1e30 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64857418 |
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
742ad76 to
d9d7bbe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64857418 |
Summary: Pull Request resolved: pytorch#138818 Test Plan: Sandcastle Reviewed By: malfet Differential Revision: D64857418
c740483 to
2bddc94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64857418 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64857418 |
|
@pytorchbot merge |
Merge failedReason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR! Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot merge -f "macos runner issues - pushing this one through" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Test Plan: Sandcastle
Differential Revision: D64857418
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10