[3/N] Fix cppcoreguidelines-special-member-functions warnings #138796

cyyever · 2024-10-24T06:32:21Z

Fixes #ISSUE_NUMBER

pytorch-bot · 2024-10-24T06:32:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138796

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5bf59f3 with merge base d2ec289 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cyyever · 2024-10-24T07:49:00Z

@pytorchbot label "topic: not user facing"

aten/src/ATen/TensorIterator.h

aten/src/ATen/core/Array.h

aten/src/ATen/core/ivalue.h

ezyang · 2024-10-27T17:47:23Z

need rebase

cyyever · 2024-10-27T23:52:18Z

@pytorchbot merge

pytorchmergebot · 2024-10-27T23:54:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

cyyever · 2024-10-28T01:36:03Z

@pytorchbot merge -f "CI passed before"

pytorchmergebot · 2024-10-28T01:36:22Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-10-28T01:37:50Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

wdvr · 2024-10-28T06:57:14Z

@pytorchmergebot revert -m "reverting since this started failing a windows test"

GH job link HUD commit link

pytorch-bot · 2024-10-28T06:57:17Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

wdvr · 2024-10-28T06:57:33Z

@pytorchmergebot revert -m "reverting since this started failing a windows test" -c ignoredsignal

GH job link HUD commit link

pytorchmergebot · 2024-10-28T06:58:50Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-10-28T06:58:50Z

Don't want to revert based on edited command

wdvr · 2024-10-28T07:04:29Z

@pytorchmergebot revert -m "reverting since this started failing a windows test" -c ignoredsignal

GH job link HUD commit link

pytorchmergebot · 2024-10-28T07:05:54Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-10-28T07:06:03Z

@cyyever your PR has been successfully reverted.

#138796)" This reverts commit 7cb3cef. Reverted #138796 on behalf of https://github.com/wdvr due to reverting since this started failing a windows test ([comment](#138796 (comment)))

cyyever · 2024-10-28T07:20:54Z

@pytorchbot merge

pytorchmergebot · 2024-10-28T07:23:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

cyyever · 2024-10-28T09:15:23Z

@pytorchbot merge -i

pytorchmergebot · 2024-10-28T09:15:42Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-10-28T09:17:25Z

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Follows #138796 Pull Request resolved: #139027 Approved by: https://github.com/ezyang

…h#139027) Follows pytorch#138796 Pull Request resolved: pytorch#139027 Approved by: https://github.com/ezyang

cyyever requested review from eqy, sraikund16 and syed-ahmed as code owners October 24, 2024 06:32

cyyever marked this pull request as draft October 24, 2024 06:33

pytorchbot added the open source label Oct 24, 2024

cyyever force-pushed the special3 branch from e61299b to 787641c Compare October 24, 2024 07:26

pytorch-bot bot added the topic: not user facing topic category label Oct 24, 2024

Fix clang-tidy warnings

c1287d1

cyyever force-pushed the special3 branch from 787641c to c1287d1 Compare October 24, 2024 08:02

cyyever changed the title ~~Fix clang-tidy warnings~~ [3/N] Fix cppcoreguidelines-special-member-functions warnings Oct 24, 2024

cyyever marked this pull request as ready for review October 24, 2024 15:16

cyyever requested review from Skylion007 and ezyang October 24, 2024 15:16

Skylion007 reviewed Oct 25, 2024

View reviewed changes

aten/src/ATen/TensorIterator.h Show resolved Hide resolved

Skylion007 reviewed Oct 25, 2024

View reviewed changes

aten/src/ATen/core/Array.h Show resolved Hide resolved

Skylion007 reviewed Oct 25, 2024

View reviewed changes

aten/src/ATen/core/ivalue.h Show resolved Hide resolved

cyyever requested a review from Skylion007 October 25, 2024 15:02

ezyang approved these changes Oct 27, 2024

View reviewed changes

Merge branch 'main' into special3

eb8ad40

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 27, 2024

pytorchmergebot added the merging label Oct 27, 2024

pytorchmergebot closed this in 7cb3cef Oct 28, 2024

pytorchmergebot added Merged and removed merging labels Oct 28, 2024

cyyever mentioned this pull request Oct 28, 2024

[4/N] Fix cppcoreguidelines-special-member-functions warnings #139027

Closed

pytorchmergebot added the Reverted label Oct 28, 2024

pytorchmergebot reopened this Oct 28, 2024

Add suppression

5bf59f3

pytorchmergebot added the merging label Oct 28, 2024

pytorchmergebot closed this in 4d9b5a8 Oct 28, 2024

pytorchmergebot removed the merging label Oct 28, 2024

cyyever deleted the special3 branch October 29, 2024 02:33

[3/N] Fix cppcoreguidelines-special-member-functions warnings #138796

[3/N] Fix cppcoreguidelines-special-member-functions warnings #138796

Uh oh!

Conversation

cyyever commented Oct 24, 2024

Uh oh!

pytorch-bot bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138796

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

cyyever commented Oct 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezyang commented Oct 27, 2024

Uh oh!

cyyever commented Oct 27, 2024

Uh oh!

pytorchmergebot commented Oct 27, 2024

Merge started

Uh oh!

cyyever commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge started

Uh oh!

wdvr commented Oct 28, 2024

Uh oh!

pytorch-bot bot commented Oct 28, 2024

Uh oh!

wdvr commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

wdvr commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

cyyever commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge started

Uh oh!

cyyever commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pytorch-bot bot commented Oct 24, 2024 •

edited

Loading

wdvr commented Oct 28, 2024 •

edited

Loading