Added option to control number of kernel options displayed #138788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Chillee wants to merge 20 commits into gh/chillee/370/base from gh/chillee/370/head

Collaborator

Chillee commented Oct 24, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov


          Added option to control number of kernel options displayed

ccb3335

[ghstack-poisoned]

pytorch-bot bot commented Oct 24, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138788

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 1919925 with merge base 78491d6 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
detectron2_fcos_r_50_fpn

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#141498)
convnext_base

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 24, 2024

Fixed max-autotune in FlexAttention to reset kernel options appropriately #138733

Closed

Made DDPOptimizer work with HOPs #138787

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels

This was referenced Oct 24, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

Closed

Turned Views, Layouts, and Loops into proper dataclasses #137861

Closed

github-actions bot requested a review from ezyang

October 24, 2024 04:39

Chillee added 2 commits

October 23, 2024 21:42


          Update on "Added option to control number of kernel options displayed"

f17e552

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]


          Update on "Added option to control number of kernel options displayed"

750de63

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee mentioned this pull request

Fix free symbol handling in FlexAttention #138794

Closed

Chillee added 2 commits

October 23, 2024 22:54


          Update on "Added option to control number of kernel options displayed"

d75d156

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]


          Update on "Added option to control number of kernel options displayed"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

zeshengzong reviewed

View reviewed changes

torch/_inductor/config.py Outdated

    
              # enable slow autotuning passes to select gemm algorithms

              max_autotune_gemm = os.environ.get("TORCHINDUCTOR_MAX_AUTOTUNE_GEMM") == "1"

              # Modifies the number

Contributor

zeshengzong Oct 24, 2024 •

edited

Loading

Suggested change

      
            # Modifies the number
          
            # Modifies the number, set None to display all

Hello, add a description for None value, might be easier to use. :D

Contributor

drisspg Dec 1, 2024

type hint that it can be optional as well


          Update on "Added option to control number of kernel options displayed"

9e34703

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee mentioned this pull request

Stop force realizing to prevent recursion errors unless it's much bigger #138881

Closed


          Update on "Added option to control number of kernel options displayed"

390c322

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee mentioned this pull request

Add some error messages for flexattention #138891

Closed

Chillee added 2 commits

October 24, 2024 22:01


          Update on "Added option to control number of kernel options displayed"

0eaeaca

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]


          Update on "Added option to control number of kernel options displayed"

16dd9a0

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee mentioned this pull request

Made FlexAttention error on subgraph lowering failure #140331

Closed


          Update on "Added option to control number of kernel options displayed"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

4ecabc8

ghstack-source-id: a54bbd2
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

e4283be

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added the topic: not user facing label


          Update on "Added option to control number of kernel options displayed"

b5bc8f7

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

999b8c2

ghstack-source-id: 7435405
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

942d757

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

a350c26

ghstack-source-id: a063454
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

df14137

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]


          Update on "Added option to control number of kernel options displayed"

c260e12

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]


          Update on "Added option to control number of kernel options displayed"

62c7645

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

f1c2b82

ghstack-source-id: bc9347f
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

d22f071

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

dfef2bc

ghstack-source-id: ad5f1d3
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

7a3bd89

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee added a commit that referenced this pull request


          Added option to control number of kernel options displayed

4d72e39

ghstack-source-id: d543013
Pull Request resolved: #138788


          Update on "Added option to control number of kernel options displayed"

e9d2e3e

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

Chillee mentioned this pull request

Ensure that BlockMask length must always exactly match the sequence length in flex_attention #141625

Closed

drisspg approved these changes

View reviewed changes


          Update on "Added option to control number of kernel options displayed"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]

pytorchmergebot added the Merged label

pytorchmergebot closed this in

8eb259f

pytorchmergebot pushed a commit that referenced this pull request


          Ensure that BlockMask length must always exactly match the sequence l…

795f28a

…ength in flex_attention (#141625)

Fixes #141435

Pull Request resolved: #141625
Approved by: https://github.com/drisspg
ghstack dependencies: #138788

pytorchmergebot pushed a commit that referenced this pull request


          Ensure that BlockMask length must always exactly match the sequence l…

af88326

…ength in flex_attention (#141625)

Fixes #141435

Pull Request resolved: #141625
Approved by: https://github.com/drisspg
ghstack dependencies: #138788

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          Added option to control number of kernel options displayed (pytorch#1…

35fd1fe

…38788)

Pull Request resolved: pytorch#138788
Approved by: https://github.com/drisspg

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          Ensure that BlockMask length must always exactly match the sequence l…

bb263de

…ength in flex_attention (pytorch#141625)

Fixes pytorch#141435

Pull Request resolved: pytorch#141625
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#138788

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          Ensure that BlockMask length must always exactly match the sequence l…

0d1fe9c

…ength in flex_attention (pytorch#141625)

Fixes pytorch#141435

Pull Request resolved: pytorch#141625
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#138788

github-actions bot deleted the gh/chillee/370/head branch

January 1, 2025 02:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor Merged module: inductor topic: not user facing