Skip to content

[CI/CD] Disable split build #138752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

[CI/CD] Disable split build #138752

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 23, 2024 •
edited
Loading

See #138750

@malfet malfet requested a review from a team as a code owner October 23, 2024 22:12
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 23, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138752

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit c927dab with merge base c924594 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

seemethere
seemethere requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the submodule updates intentional?

@malfet malfet requested a review from seemethere October 23, 2024 22:19
@malfet
Copy link
Contributor Author

malfet commented Oct 23, 2024

Were the submodule updates intentional?

If my linters still in place, mergebot would not allow me to do that unless I mention submodule in PR name

huydhn
huydhn approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also cc @wdvr as I think we want to see how much this saves

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Oct 23, 2024
@malfet
Copy link
Contributor Author

malfet commented Oct 23, 2024

Adding trunk and periodic, to make sure they are scheduled, and afterwards landing the change..

@malfet
Copy link
Contributor Author

malfet commented Oct 23, 2024

@pytorchbot merge -f "PR sanity check is not applicable here"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 23, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@malfet @SamGinzburg
[CI/CD] Disable split build (#138752)
d2e81d9 
See #138750

Pull Request resolved: #138752
Approved by: https://github.com/kit1980, https://github.com/huydhn
@github-actions github-actions bot deleted the malfet/disable-split-build branch November 24, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@seemethere seemethere Awaiting requested review from seemethere

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @kit1980 @huydhn @seemethere