Skip to content

[Distributed] Add more tests to use eager init #138644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kwen2501 wants to merge 1 commit into from
Closed

[Distributed] Add more tests to use eager init #138644

kwen2501 wants to merge 1 commit into from

Conversation

@kwen2501
Copy link
Collaborator

@kwen2501 kwen2501 commented Oct 22, 2024 •
edited by pytorch-bot bot
Loading

This was referenced Oct 22, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138644

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9791544 with merge base 195d0a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Oct 22, 2024
kwen2501 added a commit that referenced this pull request Oct 22, 2024
@kwen2501
[Distributed] Add more tests to use eager init
a34b13b 
ghstack-source-id: 5f5aa58
Pull Request resolved: #138644
wz337
wz337 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwen2501 kwen2501 mentioned this pull request Oct 24, 2024
Closed
kwen2501 added a commit that referenced this pull request Oct 24, 2024
@kwen2501
[PGNCCL] Use non-blocking mode by default in eager init
289665c 
ghstack-source-id: 23b33f1
Pull Request resolved: #138527

[Distributed] Add more tests to use eager init

ghstack-source-id: 23b33f1
Pull Request resolved: #138644
kwen2501 added a commit that referenced this pull request Oct 25, 2024
@kwen2501
[PGNCCL] Use non-blocking mode by default in eager init
5ed6981 
ghstack-source-id: f129e63
Pull Request resolved: #138527

[Distributed] Add more tests to use eager init

ghstack-source-id: f129e63
Pull Request resolved: #138644
kwen2501 added a commit that referenced this pull request Oct 25, 2024
@kwen2501
[PGNCCL] Use non-blocking mode by default in eager init
695761b 
ghstack-source-id: c21c1e2
Pull Request resolved: #138527

[Distributed] Add more tests to use eager init

ghstack-source-id: c21c1e2
Pull Request resolved: #138644
kwen2501 added a commit that referenced this pull request Oct 25, 2024
@kwen2501
[PGNCCL] Use non-blocking mode by default in eager init
50eaf14 
ghstack-source-id: 910cb59
Pull Request resolved: #138527

[Distributed] Add more tests to use eager init

ghstack-source-id: 910cb59
Pull Request resolved: #138644
@kwen2501
Copy link
Collaborator Author

kwen2501 commented Nov 2, 2024

Merged into #138527

@kwen2501 kwen2501 closed this Nov 2, 2024
@github-actions github-actions bot deleted the gh/kwen2501/82/head branch December 3, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyyever cyyever cyyever approved these changes

@wz337 wz337 wz337 approved these changes

@shuqiangzhang shuqiangzhang Awaiting requested review from shuqiangzhang

@fduwjj fduwjj Awaiting requested review from fduwjj

Assignees

No one assigned

Labels

oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwen2501 @cyyever @wz337