Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 22, 2024

Spiritual successor of #119413 + CPP docs copyright update as well
Fixes #138630

cc @svekars @brycebortree @sekyondaMeta

@malfet malfet requested a review from albanD as a code owner October 22, 2024 20:39
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138638

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 40d244c with merge base dbd0a39 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added this to the 2.5.1 milestone Oct 22, 2024
@svekars svekars added topic: not user facing topic category module: docs Related to our documentation, both in docs/ and docblocks labels Oct 22, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svekars
Copy link
Contributor

svekars commented Oct 22, 2024

There was a PR for this back in Feb FWIW: #119413

@malfet
Copy link
Contributor Author

malfet commented Oct 22, 2024

There was a PR for this back in Feb FWIW: #119413

You should have pinged more people about it

@malfet
Copy link
Contributor Author

malfet commented Oct 22, 2024

@pytorchbot merge -f "Don't even want to wait for lint"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet changed the title Update copyrights to 2024 Update doc copyrights to 2024 Oct 22, 2024
@kit1980
Copy link
Contributor

kit1980 commented Oct 22, 2024

@pytorchbot cherry-pick --onto release/2.5 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 22, 2024
Spiritual successor of #119413 + CPP docs copyright update as well
Fixes #138630

Pull Request resolved: #138638
Approved by: https://github.com/atalman

(cherry picked from commit d1be61c)
@pytorchbot
Copy link
Collaborator

Cherry picking #138638

The cherry pick PR is at #138650 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

malfet added a commit that referenced this pull request Oct 22, 2024
Update copyrights to 2024 (#138638)

Spiritual successor of #119413 + CPP docs copyright update as well
Fixes #138630

Pull Request resolved: #138638
Approved by: https://github.com/atalman

(cherry picked from commit d1be61c)

Co-authored-by: Nikita Shulga <[email protected]>
SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
Spiritual successor of #119413 + CPP docs copyright update as well
Fixes #138630

Pull Request resolved: #138638
Approved by: https://github.com/atalman
@github-actions github-actions bot deleted the malfet-patch-17 branch November 22, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation copyright year is 2023

7 participants