Skip to content

Add CUDA 12.6 to Linux CD docker images #138563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinglvv wants to merge 1 commit into from
Closed

Add CUDA 12.6 to Linux CD docker images #138563

tinglvv wants to merge 1 commit into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Oct 22, 2024 •
edited
Loading

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 22, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138563

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ddef76 with merge base 10a34dc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Oct 22, 2024

Need:
Add cuda12.6 to https://hub.docker.com/r/pytorch/libtorch-cxx11-builder/tags
Add cuda12.6 to https://hub.docker.com/r/pytorch/manylinux-builder/tags?name=cuda

@tinglvv tinglvv marked this pull request as ready for review October 22, 2024 18:04
@tinglvv tinglvv requested review from a team and jeffdaily as code owners October 22, 2024 18:04
@atalman
Copy link
Contributor

atalman commented Oct 22, 2024

HI @tinglvv looks like this is missing common/install_cuda.sh changes from https://github.com/pytorch/pytorch/pull/138417/files#diff-59a5c7b059e5f55320f04d72b66103f79344330e7f5d16df946aa3f8ca6c6261

I think we should unify both PR's

nWEIdia
nWEIdia reviewed Oct 22, 2024
View reviewed changes
nWEIdia
nWEIdia reviewed Oct 22, 2024
View reviewed changes
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2024
@tinglvv tinglvv force-pushed the 126-libtorch-manywheel branch from b61a70b to 3ddef76 Compare October 25, 2024 01:07
@malfet malfet added the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Oct 25, 2024
@malfet malfet changed the title add CUDA 12.6 libtorch and manywheel workflow Add CUDA 12.6 to Linux CD docker images Oct 25, 2024
@malfet
Copy link
Contributor

malfet commented Oct 25, 2024

@pytorchbot merge -f "Lint is green, otherwise nothing to test"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Dec 12, 2024
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nWEIdia nWEIdia nWEIdia left review comments

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tinglvv @atalman @malfet @pytorchmergebot @nWEIdia @bdhirsh @pytorchbot