[AOTI][refactor] Clean up test_aot_inductor skip list #138544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove skips for already fixed tests. Change remaining skip to xfail so that the failure list can be more proactively maintained. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138544
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 09852df with merge base 2827bef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
chenyang78
approved these changes
Oct 22, 2024
Summary: Remove skips for already fixed tests. Change remaining skip to xfail so that the failure list can be more proactively maintained. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Oct 22, 2024
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hl475
approved these changes
Oct 22, 2024
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Remove skips for already fixed tests. Change remaining skip to xfail so that the failure list can be more proactively maintained. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov Differential Revision: [D64761257](https://our.internmc.facebook.com/intern/diff/D64761257) [ghstack-poisoned]
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 23, 2024
…8379) Summary: Add missing use_minimal_arrayref_interface setting to check_model_with_multiple_inputs. Differential Revision: [D64635211](https://our.internmc.facebook.com/intern/diff/D64635211) Pull Request resolved: #138379 Approved by: https://github.com/hl475 ghstack dependencies: #138544
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Summary: Move use_minimal_arrayref_interface specific logic from CppWrapperCpu to CppWrapperCpuArrayRef. This is a copy-on-write style refactor, to simply the default AOTI generated code. Differential Revision: [D64598715](https://our.internmc.facebook.com/intern/diff/D64598715) Pull Request resolved: #138250 Approved by: https://github.com/chenyang78 ghstack dependencies: #138544, #138379
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Summary: Remove skips for already fixed tests. Change remaining skip to xfail so that the failure list can be more proactively maintained. Differential Revision: [D64761257](https://our.internmc.facebook.com/intern/diff/D64761257) Pull Request resolved: #138544 Approved by: https://github.com/chenyang78, https://github.com/hl475
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
…8379) Summary: Add missing use_minimal_arrayref_interface setting to check_model_with_multiple_inputs. Differential Revision: [D64635211](https://our.internmc.facebook.com/intern/diff/D64635211) Pull Request resolved: #138379 Approved by: https://github.com/hl475 ghstack dependencies: #138544
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Summary: Move use_minimal_arrayref_interface specific logic from CppWrapperCpu to CppWrapperCpuArrayRef. This is a copy-on-write style refactor, to simply the default AOTI generated code. Differential Revision: [D64598715](https://our.internmc.facebook.com/intern/diff/D64598715) Pull Request resolved: #138250 Approved by: https://github.com/chenyang78 ghstack dependencies: #138544, #138379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Remove skips for already fixed tests. Change remaining skip to xfail so that the failure list can be more proactively maintained.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov
Differential Revision: D64761257