[MPS] Fix sliced cast #138535
Merged
[MPS] Fix sliced cast #138535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes internal crash due to the invalid bufer size computation if sliced API is used
Not sure what was the purpose of
```c++
IntArrayRef baseShape;
if (src.is_view()) {
baseShape = src._base().sizes();
} else {
baseShape = getIMPSAllocator()->getBufferShape(src.storage().data());
}
int flattenedShaped = 1;
for (const auto i : c10::irange(baseShape.size())) {
flattenedShaped *= baseShape[i];
}
```
As flattenShaped could be much easier computed as `[srcBuf
lengh]/src.element_size()`, and even if `srcBuf` is padded it's a safe thing to do.
When someone allocated buffer to hold say uint8 and that view-casted it
to float16, attempt to compute `baseShape` returned sizes of original
tensor in its data type, rather than size in new dtypes
Fixes #137800
Pull Request resolved: #138314
Approved by: https://github.com/albanD, https://github.com/DenisVieriu97
(cherry picked from commit de16159)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138535
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6db59b4 with merge base b7eb725 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
malfet
approved these changes
Oct 22, 2024
github-actions
bot
deleted the
cherry-pick-138314-by-pytorch_bot_bot_
branch
aostrowski-hbn
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Jan 7, 2025
pytorch/pytorch@v2.5.0...v2.5.1 Squashed new commits are as follows: * update getting started xpu (pytorch#138090) * [Cherry-Pick] Use cuda 12.4 pytorch_extra_install_requirements as default (pytorch#138526) * Don't try to load cufile (pytorch#138539) * Add link to torch.compile the missing manual in troubleshooting (pytorch#137369) * Update cpuinfo submodule (pytorch#138600) * Update doc copyrights to 2024 (pytorch#138650) * [SDPA-CUDNN] Make CuDNN Attention Opt in (pytorch#138587) * [MPS] Fix sliced cast (pytorch#138535) * Disabling amp context when invoking compiler (pytorch#138659) Change-Id: I3e282e8b4809b97b38605420c64d1bd1b0b938aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes internal crash due to the invalid bufer size computation if sliced API is used
Not sure what was the purpose of
As flattenShaped could be much easier computed as
[srcBuf lengh]/src.element_size(), and even ifsrcBufis padded it's a safe thing to do.When someone allocated buffer to hold say uint8 and that view-casted it
to float16, attempt to compute
baseShapereturned sizes of originaltensor in its data type, rather than size in new dtypes
Fixes #137800