[inductor] Allow cooperative + persistent reductions #138533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138533
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 431bda7 with merge base 07b0d63 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
shunting314
approved these changes
Oct 28, 2024
| # The RSPLIT of cooperative reductions means each thread block is operating on fewer elements | ||
| xnumel, _ = self.numels | ||
| try: | ||
| threshold *= 32 // V.graph.sizevars.size_hint(xnumel) |
Contributor
There was a problem hiding this comment.
So 32 // V.graph.sizevars.size_hint(xnumel) is used to estimate RSPLIT?
Is it expected that this is not that consistent to the similar logic in triton_heuristics.cooperative_reduction :
split = max(1, min(target // xnumel, TRITON_MAX_RSPLIT))
target is 64 there.
Contributor
Author
There was a problem hiding this comment.
Yeah, though I'm intentionally under-estimating here to be conservative.
eellison
approved these changes
Oct 28, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Pull Request resolved: #138893 Approved by: https://github.com/shunting314 ghstack dependencies: #138533
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Pull Request resolved: pytorch#138893 Approved by: https://github.com/shunting314 ghstack dependencies: pytorch#138533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov