[easy] in ROCmTemplate set kwargs when creating Buffer #138521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: pytorch#137768 makes Inductor IR kw only Test Plan: CI Differential Revision: D64723804
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138521
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cde2483 with merge base 7786869 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
ciflow/rocm
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64723804 |
Contributor
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
tenpercent
approved these changes
Oct 21, 2024
Collaborator
tenpercent
left a comment
tenpercent
left a comment
There was a problem hiding this comment.
looks good, thanks for fixing!
chenyang78
approved these changes
Oct 22, 2024
Contributor
Author
|
@pytorchbase merge |
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Summary: #137768 makes Inductor IR kw only Test Plan: CI Differential Revision: D64723804 Pull Request resolved: #138521 Approved by: https://github.com/tenpercent, https://github.com/chenyang78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #137768 makes Inductor IR kw only
Test Plan: CI
Differential Revision: D64723804
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @desertfire @chauhang @aakhundov