Don't try to load cufile #138501
Closed
Don't try to load cufile #138501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138501
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 075efb5 with merge base c1ead6f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
mikaylagawarecki
approved these changes
Oct 21, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
approved these changes
Oct 21, 2024
malfet
added
release notes: build
Contributor
Author
|
@pytorchbot cherry-pick --onto release/2.5 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet (cherry picked from commit 012ff2a)
Collaborator
Cherry picking #138501The cherry pick PR is at #138539 and it is recommended to link a critical cherry pick PR with an issue. Details for Dev Infra teamRaised by workflow job |
kit1980
added a commit
that referenced
this pull request
Oct 22, 2024
Don't try to load cufile (#138501) Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet (cherry picked from commit 012ff2a) Co-authored-by: Sergii Dymchenko <[email protected]>
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to loading it caused a big issue with 2.5.0 release - #138324
cufile is not actually used currently by default, see #133489