Skip to content

Remove torch/csrc/api/include/torch/linalg.h #138435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyyever wants to merge 1 commit into from
Closed

Remove torch/csrc/api/include/torch/linalg.h #138435

cyyever wants to merge 1 commit into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 21, 2024 •
edited
Loading

Only one place in OSS uses it.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138435

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 4 Unrelated Failures

As of commit 08e87f1 with merge base 2d3455e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Oct 21, 2024
@cyyever cyyever added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Oct 21, 2024
@cyyever cyyever requested a review from r-barnes October 21, 2024 03:32
r-barnes
r-barnes approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@r-barnes r-barnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, go for it.

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2024
@cyyever cyyever added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 21, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2024

Merge failed

Reason: 5 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_10-xpu-build / build, linux-binary-manywheel / manywheel-py3_9-xpu-build / build, linux-binary-manywheel / manywheel-py3_12-xpu-build / build, linux-binary-manywheel / manywheel-py3_11-xpu-build / build, linux-binary-manywheel / manywheel-py3_13-xpu-build / build

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 21, 2024

@pytorchmergebot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

matthewhagraphcore pushed a commit to matthewhagraphcore/pytorch that referenced this pull request Oct 21, 2024
@cyyever @matthewhagraphcore
Remove torch/csrc/api/include/torch/linalg.h (pytorch#138435)
da8ef84 
Only one place in OSS uses it.
Pull Request resolved: pytorch#138435
Approved by: https://github.com/r-barnes
@cyyever cyyever deleted the remove_ling branch October 29, 2024 02:35
@ybubnov ybubnov mentioned this pull request Mar 28, 2025
Merged
@MClemot MClemot mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-barnes r-barnes r-barnes approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cpp release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @r-barnes @pytorchbot