Skip to content

[c10d] Reorder cpp stack dump and FR dump and add log prefix to loggings #138368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fduwjj wants to merge 1 commit into from
Closed

[c10d] Reorder cpp stack dump and FR dump and add log prefix to loggings #138368

fduwjj wants to merge 1 commit into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Oct 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

The rationale behind this PR is to:

  1. Move the dump of c++ traces after FR dump because the FR dump is timed meaning that it will not block forever, while the dumping of c++ traces is likely to be blocking. so that we swap the order. Ideally we also want to make cpp stacktrace dump to be a future wait, if we want to go down this path, we can also make it happen in an another PR.
  2. Add log Prefix to the logs which have not been added.

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o

fduwjj added a commit that referenced this pull request Oct 18, 2024
@fduwjj
[c10d] Reorder cpp stack dump and FR dump and add log prefix to loggings
c9389cb 
ghstack-source-id: 5ee43d1
Pull Request resolved: #138368
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 18, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit dd88db2 with merge base de51ed8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fduwjj fduwjj added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
@fduwjj
Copy link
Contributor Author

fduwjj commented Oct 18, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 18, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 18, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build

Details for Dev Infra team Raised by workflow job

@c-p-i-o
Copy link
Contributor

c-p-i-o commented Oct 18, 2024

@pytorchbot merge -i
linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build failure is unrelated to this change.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 18, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 18, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Oct 19, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged while ignoring the following 5 checks: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fduwjj fduwjj mentioned this pull request Oct 23, 2024
Closed
@github-actions github-actions bot deleted the gh/fduwjj/150/head branch November 19, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wconstab wconstab Awaiting requested review from wconstab

1 more reviewer

@c-p-i-o c-p-i-o c-p-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fduwjj @pytorchmergebot @c-p-i-o