C10_UNUSED to [[maybe_unused]] (#6357) #138364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
requested review from
EikanWang,
IvanYashchuk,
aaronenyeshi,
albanD,
digantdesai,
eqy,
gujinghui,
jerryzh168,
jianyuh,
jiayisuse,
kimishpatel,
kulinseth,
lezcano,
lw,
malfet,
nikitaved,
osalpekar,
salilsdesai,
shubhambhokare1,
soulitzer,
sraikund16,
syed-ahmed and
titaiwangms
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138364
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 809e354 with merge base fecd370 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
Skylion007
approved these changes
Oct 18, 2024
eqy
approved these changes
Oct 18, 2024
r-barnes
added a commit
to r-barnes/executorch
that referenced
this pull request
Oct 19, 2024
Summary: X-link: pytorch/pytorch#138364 Differential Revision: D64613643
r-barnes
force-pushed
the
export-D64613643
branch
from
4ebd81c to
6b6ae64
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64613643 |
r-barnes
added a commit
to r-barnes/executorch
that referenced
this pull request
Oct 19, 2024
Summary: X-link: pytorch/pytorch#138364 Reviewed By: dmm-fb Differential Revision: D64613643
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64613643 |
r-barnes
force-pushed
the
export-D64613643
branch
from
098daf2 to
ffd289b
Compare
Summary: Pull Request resolved: pytorch#138364 X-link: pytorch/executorch#6357 Test Plan: Sandcastle Reviewed By: dmm-fb Differential Revision: D64613643
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64613643 |
r-barnes
force-pushed
the
export-D64613643
branch
from
ffd289b to
809e354
Compare
Contributor
Author
|
@pytorchbot merge -f "ignore internals" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Oct 19, 2024
Summary: X-link: pytorch/pytorch#138364 Pull Request resolved: #6357 Reviewed By: dmm-fb Differential Revision: D64613643 fbshipit-source-id: 8c0608376e5b21d9d3291bef6ae75e7d826d86bb
Contributor
|
@r-barnes Why did you |
github-merge-queue bot
pushed a commit
to intel/torch-xpu-ops
that referenced
this pull request
Oct 21, 2024
# Motivation Accroding to pytorch/pytorch#138364 to use `[[maybe_unused]]` to suppress the unused warning. Maybe it could fix the [issue](#987) introduced by https://github.com/intel/torch-xpu-ops/pull/770/files#diff-ae810fb2aff5cf37ab1b21244fd1e172a660a8e4f4b9292f0661af64c2f92b21L15.
This was referenced Oct 22, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 24, 2024
# Motivation Fix #138577. # Solution 1. All UTs in `test/inductor/test_compiled_optimizers.py` are fixed by #134170 2. UT in `test/inductor/test_pattern_matcher.py` is introduced by #138089, we will skip this UT due to the unsupported feature `max_autotune_gemm_backends:Triton`. 3. We have a new impl related to `histc`, so we remove the expected failure from `test/inductor/test_torchinductor_opinfo.py` 4. We support `avg_pool3d` for `fp16` data type, so we remove the expected failure from `test/inductor/test_torchinductor_opinfo.py` 5. CUDA-bias code is introduced by #138472, we just generalize it to `GPU_TYPE`. # Additional Context > Why update torch-xpu-ops commit pin here? We have to update commit pin to avoid the build failure raised by the code change [C10_UNUSED](#138364). > What does the feature of torch-xpu-ops update? 1. Add some foreach ops, like `unary ops` and `foreach_clamp_max` etc; 2. Add some maxpool ops forward and backward, like `averge_pool3d` and `max_pool3d` 3. Add some other ops, like `log_normal_`, `index_copy`, and `mode` etc; 4. fix build failure related to `C10_UNUSED`; Pull Request resolved: #138548 Approved by: https://github.com/malfet, https://github.com/EikanWang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: pytorch/executorch#6357
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @EikanWang