Skip to content

[aot_compile] propagate ShapeEnv during lowering #138362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pianpwk wants to merge 1 commit into from
Closed

[aot_compile] propagate ShapeEnv during lowering #138362

pianpwk wants to merge 1 commit into from

Conversation

@pianpwk
Copy link
Contributor

@pianpwk pianpwk commented Oct 18, 2024 •
edited
Loading

We found that export() -> _inductor.aot_compile() lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused.

Differential Revision: D64613290

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @rec

@pianpwk pianpwk requested a review from bdhirsh as a code owner October 18, 2024 19:27
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138362

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a808449 with merge base 96b30dc (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 18, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

facebook-github-bot pushed a commit that referenced this pull request Oct 18, 2024
@pianpwk @facebook-github-bot
[aot_compile] propagate ShapeEnv during lowering (#138362)
3411fa6 
Summary: Pull Request resolved: #138362

Differential Revision: D64613290
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 18, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
pianpwk
pianpwk commented Oct 18, 2024
View reviewed changes
test/inductor/test_aot_inductor.py
self.check_model(Model(), example_inputs)


class AOTInductorLoggingTest(LoggingTestCase):
Copy link
Contributor Author

@pianpwk pianpwk Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure where to put this

facebook-github-bot pushed a commit that referenced this pull request Oct 18, 2024
@pianpwk @facebook-github-bot
[aot_compile] propagate ShapeEnv during lowering (#138362)
8138621 
Summary: Pull Request resolved: #138362

Differential Revision: D64613290
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 18, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 21, 2024

@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 22, 2024

@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 23, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 23, 2024

@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 23, 2024

@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

@pianpwk @facebook-github-bot
[aot_compile] propagate ShapeEnv during lowering (#138362)
a808449 
Summary:
We found that `export() -> _inductor.aot_compile()` lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov rec


Reviewed By: ColinPeppler

Differential Revision: D64613290

Pulled By: pianpwk
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D64613290

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 24, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@wdvr
Copy link
Contributor

wdvr commented Oct 24, 2024

@pytorchmergebot merge -f "skipping pending macos job"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 24, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 24, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the export-D64613290 branch November 25, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh bdhirsh is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo module: inductor release notes: AO frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pianpwk @facebook-github-bot @pytorchmergebot @wdvr @angelayi