Skip to content

Conversation

@jeongseok-meta
Copy link
Contributor

simpy was pinned to version 1.13.1 due to test failures with version 1.13.2 on Windows and mac, as reported in #133235. Now that a newer version, 1.13.3, has been released, this PR aims to verify if the test failure has been resolved and also allow building with newer versions for packaging purposes (e.g., conda-forge/pytorch-cpu-feedstock#277 (comment)).

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138338

Note: Links to docs will display an error until the docs builds have been completed.

❌ 22 New Failures, 4 Unrelated Failures

As of commit 6b8d641 with merge base e8b1409 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 18, 2024
Skylion007
Skylion007 previously approved these changes Oct 18, 2024
@jeongseok-meta
Copy link
Contributor Author

The CI builds have been running smoothly with no errors so far, which is great! I wish an expert could take a look to ensure that simpy version 1.13.3 has been thoroughly tested and that the tests are sufficient to resolve the failures encountered in version 1.13.2. Unfortunately, I am unable to do so at the moment due to my limited knowledge of the build system and the repro of the original test failures.

@jeongseok-meta jeongseok-meta marked this pull request as ready for review October 18, 2024 17:53
@jeongseok-meta jeongseok-meta requested review from a team and jeffdaily as code owners October 18, 2024 17:53
@Skylion007 Skylion007 requested a review from atalman October 18, 2024 17:54
@Skylion007 Skylion007 added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
@Skylion007 Skylion007 requested a review from malfet October 18, 2024 17:54
@Skylion007 Skylion007 added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 18, 2024
@Skylion007 Skylion007 added this to the 2.5.1 milestone Oct 18, 2024
@Skylion007
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased simpy_pinning onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout simpy_pinning && git pull --rebase)

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have open-ended dependencies in setup.py, but please pin the dependency in CI, because if say 1.14 is released and it will be broken, it will start showing up on random PR and this is why we pin all the dependencies

malfet
malfet previously approved these changes Oct 19, 2024
@malfet malfet changed the title Relax sympy version constraint to >=1.13.1, !=1.13.2 Update sympy version constraint to 1.13.3 Oct 19, 2024
@jeongseok-meta
Copy link
Contributor Author

Some CI jobs failed with the following errors:

INFO: pip is looking at multiple versions of torch to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement sympy>=1.13.3; python_version >= "3.9" (from torch) (from versions: 1.10.1, 1.11.1, 1.12, 1.12.1, 1.13.1)
ERROR: No matching distribution found for sympy>=1.13.3; python_version >= "3.9"

I am unsure why PyPI cannot find version 1.13.3 when it is available (https://pypi.org/project/sympy/1.13.3/). Perhaps there is a cache that needs to be updated?

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: windows-binary-wheel / wheel-py3_9-xpu-build, windows-binary-wheel / wheel-py3_10-xpu-build, windows-binary-wheel / wheel-py3_11-xpu-build, windows-binary-wheel / wheel-py3_12-xpu-build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Oct 20, 2024

@pytorchbot merge -i

@huydhn
Copy link
Contributor

huydhn commented Oct 20, 2024

@pytorchbot revert -m 'Sorry for reverting your change, but I think a bunch of inductor tests and test_dynamic_shapes are failing in trunk after this lands https://hud.pytorch.org/pytorch/pytorch/commit/d8279ad9d162b5ce71699f462d3664c3745b14f5' -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@jeongseok-meta your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 20, 2024
@pytorch-bot pytorch-bot bot dismissed stale reviews from Skylion007 and malfet October 20, 2024 03:19

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@Skylion007
Copy link
Collaborator

FYI, we should also update the dependencies in lintrunner.toml (used type checking).

@malfet
Copy link
Contributor

malfet commented Oct 21, 2024

Removing 2.5.1 milestone, @Skylion007 why do you think it's important enough to be included into 2.5.1? (Dependency updates are usually not something one should do lightly)

@malfet malfet removed this from the 2.5.1 milestone Oct 21, 2024
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@jeongseok-meta
Copy link
Contributor Author

For the record, this issue has been resolved by #143908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted Stale topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants