-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Update sympy version constraint to 1.13.3 #138338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The CI builds have been running smoothly with no errors so far, which is great! I wish an expert could take a look to ensure that simpy version 1.13.3 has been thoroughly tested and that the tests are sufficient to resolve the failures encountered in version 1.13.2. Unfortunately, I am unable to do so at the moment due to my limited knowledge of the build system and the repro of the original test failures. |
|
Please seek CI approval before scheduling CIFlow labels |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
8cf6741 to
fb5654a
Compare
fb5654a to
431c178
Compare
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have open-ended dependencies in setup.py, but please pin the dependency in CI, because if say 1.14 is released and it will be broken, it will start showing up on random PR and this is why we pin all the dependencies
Co-authored-by: Nikita Shulga <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>
|
Some CI jobs failed with the following errors: I am unsure why PyPI cannot find version 1.13.3 when it is available (https://pypi.org/project/sympy/1.13.3/). Perhaps there is a cache that needs to be updated? |
Merge startedYour change will be merged while ignoring the following 4 checks: windows-binary-wheel / wheel-py3_9-xpu-build, windows-binary-wheel / wheel-py3_10-xpu-build, windows-binary-wheel / wheel-py3_11-xpu-build, windows-binary-wheel / wheel-py3_12-xpu-build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 5 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_12-xpu-build / build, linux-binary-manywheel / manywheel-py3_13-xpu-build / build, linux-binary-manywheel / manywheel-py3_11-xpu-build / build, linux-binary-manywheel / manywheel-py3_10-xpu-build / build, linux-binary-manywheel / manywheel-py3_9-xpu-build / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 10 checks: windows-binary-wheel / wheel-py3_9-xpu-build, windows-binary-wheel / wheel-py3_10-xpu-build, windows-binary-wheel / wheel-py3_11-xpu-build, windows-binary-wheel / wheel-py3_12-xpu-build, linux-binary-manywheel / manywheel-py3_12-xpu-build / build, linux-binary-manywheel / manywheel-py3_13-xpu-build / build, linux-binary-manywheel / manywheel-py3_11-xpu-build / build, linux-binary-manywheel / manywheel-py3_10-xpu-build / build, linux-binary-manywheel / manywheel-py3_9-xpu-build / build, trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Sorry for reverting your change, but I think a bunch of inductor tests and test_dynamic_shapes are failing in trunk after this lands https://hud.pytorch.org/pytorch/pytorch/commit/d8279ad9d162b5ce71699f462d3664c3745b14f5' -c ignoredsignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@jeongseok-meta your PR has been successfully reverted. |
This reverts commit d8279ad. Reverted #138338 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but I think a bunch of inductor tests and test_dynamic_shapes are failing in trunk after this lands https://hud.pytorch.org/pytorch/pytorch/commit/d8279ad9d162b5ce71699f462d3664c3745b14f5 ([comment](#138338 (comment)))
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
|
FYI, we should also update the dependencies in lintrunner.toml (used type checking). |
|
Removing 2.5.1 milestone, @Skylion007 why do you think it's important enough to be included into 2.5.1? (Dependency updates are usually not something one should do lightly) |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
For the record, this issue has been resolved by #143908 |
simpywas pinned to version 1.13.1 due to test failures with version 1.13.2 on Windows and mac, as reported in #133235. Now that a newer version, 1.13.3, has been released, this PR aims to verify if the test failure has been resolved and also allow building with newer versions for packaging purposes (e.g., conda-forge/pytorch-cpu-feedstock#277 (comment)).