[PyTorch] Support non-zero beta in fp16_gemv_trans #138275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138275
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b5f693 with merge base 86602a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
module: cpu
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
This was referenced Oct 17, 2024
swolchok
added a commit
that referenced
this pull request
Oct 17, 2024
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) ghstack-source-id: 248664899 Pull Request resolved: #138275
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
swolchok
added a commit
that referenced
this pull request
Oct 18, 2024
Pull Request resolved: #138275 No real reason to have the zero-beta restriction, so let's lift it. ghstack-source-id: 248698384 @exported-using-ghexport Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/)
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
This was referenced Oct 22, 2024
swolchok
added a commit
that referenced
this pull request
Oct 22, 2024
Pull Request resolved: #138275 No real reason to have the zero-beta restriction, so let's lift it. ghstack-source-id: 249382372 @exported-using-ghexport Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/)
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
swolchok
added a commit
that referenced
this pull request
Oct 22, 2024
Pull Request resolved: #138275 No real reason to have the zero-beta restriction, so let's lift it. ghstack-source-id: 249400157 @exported-using-ghexport Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/)
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
This was referenced Oct 28, 2024
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
This was referenced Oct 29, 2024
No real reason to have the zero-beta restriction, so let's lift it. Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64407752 |
malfet
approved these changes
Nov 1, 2024
malfet
reviewed
Nov 1, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Would be nice to mention whether or not it's already covered by tests (should be, but worth checking IMO)
Contributor
|
@pytorchbot merge -f "ARM builds looks good" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: pytorch#138275 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918, pytorch#138005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
No real reason to have the zero-beta restriction, so let's lift it.
Testing: intentionally broke new paths locally to verify test coverage existed
Differential Revision: D64407752
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10