bug in unbacked_bindings for a*u0 #138136
Conversation
Summary: we were storing a*u0 instead of u0 in unbacked_bindings / unbacked_var_to_val Test Plan: - Differential Revision: D64508936
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138136
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4f60f76 with merge base 853da16 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64508936 |
|
Needs test |
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Logic change looks correct
Summary: we were storing a*u0 instead of u0 in unbacked_bindings / unbacked_var_to_val Test Plan: - Reviewed By: ezyang Differential Revision: D64508936
facebook-github-bot
force-pushed
the
export-D64508936
branch
from
f3327b1 to
9c5b8ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64508936 |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: we were storing a*u0 instead of u0 in unbacked_bindings / unbacked_var_to_val Test Plan: - Differential Revision: D64508936 Pull Request resolved: #138136 Approved by: https://github.com/ezyang
4 participants
Summary: we were storing a*u0 instead of u0 in unbacked_bindings / unbacked_var_to_val
Test Plan: -
Differential Revision: D64508936