[c10d] Refactor CUDAEventCache Create to use deque rather than stack #138048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138048
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c62c197 with merge base a77bb85 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
fduwjj
changed the title
wconstab
reviewed
Oct 16, 2024
This was referenced Oct 16, 2024
kwen2501
approved these changes
Oct 16, 2024
Collaborator
kwen2501
left a comment
kwen2501
left a comment
There was a problem hiding this comment.
LGTM.
nit: not related to this PR, but would be nice if Create can have more in-line comments.
Contributor
Author
|
@pytorchbot merge |
Contributor
Author
|
@kwen2501 will add in a follow-up PR. |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2024
…138059) We created a simple test to validate the cache is indeed working and when the cache is indeed used up. I revert the fix in (#138040) and the test indeed failed. Pull Request resolved: #138059 Approved by: https://github.com/kwen2501 ghstack dependencies: #138040, #138048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We used a LIFO stack to store the CudaEvent in the cache. ,Somehow we like FIFO deque better so aside from improving the readability of the code, we use a deque instead. As @wconstab pointed out, both methods are equally correct because the moment we put the event into stack/deque, the event is already ready for reuse, this change mostly is a preference change not trying to fix anything.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o