[dynamo] add some cpython debugging methods #138030

williamwen42 · 2024-10-15T22:37:50Z

Stack from ghstack (oldest at bottom):

This PR enables you to inspect PyObjects in C using INSPECT(...) without requiring https://docs.python.org/3/howto/gdb_helpers.html. torch._dynamo.eval_frame.raise_sigtrap can also be used to set gdb breakpoints while running Python code, e.g.

x = x + 1
torch._dynamo.eval_frame.raise_sigtrap();
# can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C.
x = torch.sin(x)

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

[ghstack-poisoned]

pytorch-bot · 2024-10-15T22:37:54Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138030

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c180c5a with merge base d2ec289 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: dc49ab5 Pull Request resolved: #138030

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

StrongerXi · 2024-10-21T16:47:12Z

torch/csrc/dynamo/debug_macros.h

+// WARNING: makes a Python function call! Make sure eval frame callback is
+// unset!


makes a Python function call! Make sure eval frame callback is unset!

Any chance we could automate this in the macro, like adding some wrapper calls to unset and reset the callback?

This PR enables you to inspect PyObjects in C using `INSPECT(...)` without requiring https://docs.python.org/3/howto/gdb_helpers.html. `torch._dynamo.eval_frame.raise_sigtrap` can also be used to set gdb breakpoints while running Python code, e.g. ```python x = x + 1 torch._dynamo.eval_frame.raise_sigtrap(); # can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C. x = torch.sin(x) ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

williamwen42 · 2024-10-23T18:39:35Z

@pytorchbot merge

pytorchmergebot · 2024-10-23T18:41:23Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-23T18:41:55Z

Merge failed

Reason: 15 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_freezing_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_amp_freezing_torchbench, 2, 2, linux.16xlarge.spr), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_aot_inductor_freezing_torchbench, 2, 2, linux.12xlarge)

Details for Dev Infra team

Raised by workflow job

williamwen42 · 2024-10-24T17:39:39Z

@pytorchbot merge

pytorchmergebot · 2024-10-24T17:41:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-24T17:42:02Z

Merge failed

Reason: 15 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_freezing_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_amp_freezing_torchbench, 2, 2, linux.16xlarge.spr), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_aot_inductor_freezing_torchbench, 2, 2, linux.12xlarge)

Details for Dev Infra team

Raised by workflow job

williamwen42 · 2024-10-24T18:36:11Z

@pytorchbot rebase

pytorchmergebot · 2024-10-24T18:37:37Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2024-10-24T18:37:51Z

Successfully rebased gh/williamwen42/145/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138030)

ghstack-source-id: a8df56e Pull Request resolved: #138030

This PR enables you to inspect PyObjects in C using `INSPECT(...)` without requiring https://docs.python.org/3/howto/gdb_helpers.html. `torch._dynamo.eval_frame.raise_sigtrap` can also be used to set gdb breakpoints while running Python code, e.g. ```python x = x + 1 torch._dynamo.eval_frame.raise_sigtrap(); # can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C. x = torch.sin(x) ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

[ghstack-poisoned]

pytorchmergebot · 2024-10-28T17:43:46Z

Rebased gh/williamwen42/150/orig onto refs/remotes/origin/viable/strict because #138284 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138030)

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. Pull Request resolved: #138284 Approved by: https://github.com/jansel ghstack dependencies: #138030

Summary: This PR enables you to inspect PyObjects in C using `INSPECT(...)` without requiring https://docs.python.org/3/howto/gdb_helpers.html. `torch._dynamo.eval_frame.raise_sigtrap` can also be used to set gdb breakpoints while running Python code, e.g. ```python x = x + 1 torch._dynamo.eval_frame.raise_sigtrap(); # can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C. x = torch.sin(x) ``` X-link: pytorch/pytorch#138030 Approved by: https://github.com/jansel Reviewed By: huydhn Differential Revision: D65104659 Pulled By: williamwen42 fbshipit-source-id: aa2f3f9c34a1ee15160ccc82bf61c740b3ac6d20

This PR enables you to inspect PyObjects in C using `INSPECT(...)` without requiring https://docs.python.org/3/howto/gdb_helpers.html. `torch._dynamo.eval_frame.raise_sigtrap` can also be used to set gdb breakpoints while running Python code, e.g. ```python x = x + 1 torch._dynamo.eval_frame.raise_sigtrap(); # can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C. x = torch.sin(x) ``` Pull Request resolved: pytorch#138030 Approved by: https://github.com/jansel

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. Pull Request resolved: pytorch#138284 Approved by: https://github.com/jansel ghstack dependencies: pytorch#138030

This PR enables you to inspect PyObjects in C using `INSPECT(...)` without requiring https://docs.python.org/3/howto/gdb_helpers.html. `torch._dynamo.eval_frame.raise_sigtrap` can also be used to set gdb breakpoints while running Python code, e.g. ```python x = x + 1 torch._dynamo.eval_frame.raise_sigtrap(); # can breakpoint on ceval.c:CALL to breakpoint the `sin` call in C. x = torch.sin(x) ``` Pull Request resolved: pytorch#138030 Approved by: https://github.com/jansel

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. Pull Request resolved: pytorch#138284 Approved by: https://github.com/jansel ghstack dependencies: pytorch#138030

[dynamo] add some cpython debugging methods

264a446

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 15, 2024

williamwen42 added a commit that referenced this pull request Oct 15, 2024

[dynamo] add some cpython debugging methods

ca41ea8

ghstack-source-id: dc49ab5 Pull Request resolved: #138030

williamwen42 added the topic: not user facing topic category label Oct 15, 2024

Update on "[dynamo] add some cpython debugging methods"

3b1c714

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

williamwen42 mentioned this pull request Oct 17, 2024

[dynamo] handle 3.13.0 __dict__ watcher bug #138284

Closed

StrongerXi reviewed Oct 21, 2024

View reviewed changes

williamwen42 added 2 commits October 22, 2024 14:26

williamwen42 requested review from anijain2305, jansel and mlazos October 22, 2024 21:38

williamwen42 added 2 commits October 22, 2024 14:41

jansel approved these changes Oct 23, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2024

pytorchmergebot added the merging label Oct 23, 2024

pytorchmergebot removed the merging label Oct 23, 2024

pytorchmergebot added the merging label Oct 24, 2024

pytorchmergebot removed the merging label Oct 24, 2024

Update

763d9a3

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Oct 24, 2024

[dynamo] add some cpython debugging methods

8a0d2b8

ghstack-source-id: a8df56e Pull Request resolved: #138030

williamwen42 added 2 commits October 25, 2024 13:49

Update

c180c5a

[ghstack-poisoned]

pytorchmergebot added the Merged label Oct 28, 2024

pytorchmergebot closed this in 35be6ae Oct 28, 2024

github-actions bot deleted the gh/williamwen42/145/head branch November 28, 2024 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dynamo] add some cpython debugging methods #138030

[dynamo] add some cpython debugging methods #138030

williamwen42 commented Oct 15, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

StrongerXi Oct 21, 2024

Uh oh!

williamwen42 commented Oct 23, 2024

Uh oh!

pytorchmergebot commented Oct 23, 2024

Uh oh!

pytorchmergebot commented Oct 23, 2024

Uh oh!

williamwen42 commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

williamwen42 commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		// WARNING: makes a Python function call! Make sure eval frame callback is
		// unset!

[dynamo] add some cpython debugging methods #138030

[dynamo] add some cpython debugging methods #138030

Conversation

williamwen42 commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138030

✅ No Failures

Uh oh!

StrongerXi Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

williamwen42 commented Oct 23, 2024

Uh oh!

pytorchmergebot commented Oct 23, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 23, 2024

Merge failed

Uh oh!

williamwen42 commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 24, 2024

Merge failed

Uh oh!

williamwen42 commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 24, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

williamwen42 commented Oct 15, 2024 •

edited

Loading

pytorch-bot bot commented Oct 15, 2024 •

edited

Loading