🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137859

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8e95504 with merge base a89cf2b ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Heads up, while this isn't explicitly checked until Python 3.13 (after which it errors) any frozen dataclass must have all it's subclasses also be frozen.

Also, if you are freezing all these classes too, you may want to consider slots=True later on as well for extra memory savings + performance

@Skylion007

Also, if you are freezing all these classes too, you may want to consider slots=True later on as well for extra memory savings + performance

I've found it useful to be able to set attributes in __post_init__ still with __setattr__.

Heads up, while this isn't explicitly checked until Python 3.13 (after which it errors) any frozen dataclass must have all it's subclasses also be frozen.

Are you referring to python/cpython#109409? I think this is still checked in mypy

I've found it useful to be able to set attributes in __post_init__ still with __setattr__.

You can still set attributes in __post_init__ with slots = True as long as their name and type is pre-declared? You can also just pass init=False to the dataclass fields

@Skylion007

Also, if you are freezing all these classes too, you may want to consider slots=True later on as well for extra memory savings + performance

I've found it useful to be able to set attributes in __post_init__ still with __setattr__.

Heads up, while this isn't explicitly checked until Python 3.13 (after which it errors) any frozen dataclass must have all it's subclasses also be frozen.

Are you referring to python/cpython#109409? I think this is still checked in mypy

Cool, Python 3.13 explicitly checks it at runtime too

@pytorchbot merge -f "One job stuck"

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team