Refactored debug_extra to be on ChoiceCaller (and called description) #137857

Chillee · 2024-10-13T09:50:24Z

Stack from ghstack (oldest at bottom):

Before:

After:

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-10-13T09:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137857

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b8c4b09 with merge base d1b87e2 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…escription)" Before: <img width="644" alt="image" src="https://github.com/user-attachments/assets/17b0fa8a-37c8-494b-8914-9d42c3db4bef"> After: <img width="1292" alt="image" src="https://github.com/user-attachments/assets/5ee59747-a34f-4dd6-b943-cb5a53d52080"> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ezyang · 2024-10-13T12:26:21Z

torch/_inductor/ir.py

        self.name = name
        self.layout = layout
        self.input_nodes = input_nodes
+        self.description = description


Do you mind documenting it? A type would also be good

yeah it's just a string

…escription)" Before: <img width="644" alt="image" src="https://github.com/user-attachments/assets/17b0fa8a-37c8-494b-8914-9d42c3db4bef"> After: <img width="1292" alt="image" src="https://github.com/user-attachments/assets/5ee59747-a34f-4dd6-b943-cb5a53d52080"> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Chillee · 2024-10-13T22:36:50Z

@pytorchbot merge -i

pytorchmergebot · 2024-10-13T22:38:34Z

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / linux-jammy-cpu-py3.12-gcc11-inductor-triton-cpu / test (inductor-triton-cpu, 1, 1, lf.linux.12xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-13T23:20:14Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…escription)" Before: <img width="644" alt="image" src="https://github.com/user-attachments/assets/17b0fa8a-37c8-494b-8914-9d42c3db4bef"> After: <img width="1292" alt="image" src="https://github.com/user-attachments/assets/5ee59747-a34f-4dd6-b943-cb5a53d52080"> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Chillee · 2024-10-14T06:16:13Z

@pytorchbot merge

pytorchmergebot · 2024-10-14T06:17:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-14T06:38:41Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…escription)" Before: <img width="644" alt="image" src="https://github.com/user-attachments/assets/17b0fa8a-37c8-494b-8914-9d42c3db4bef"> After: <img width="1292" alt="image" src="https://github.com/user-attachments/assets/5ee59747-a34f-4dd6-b943-cb5a53d52080"> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Chillee · 2024-10-14T19:48:58Z

@pytorchbot merge

pytorchmergebot · 2024-10-14T19:50:40Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Chillee · 2024-10-15T00:46:16Z

@pytorchbot merge -f "queue too long"

pytorchmergebot · 2024-10-15T00:46:34Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-10-15T00:48:05Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…#137857) Before: <img width="644" alt="image" src="https://github.com/user-attachments/assets/17b0fa8a-37c8-494b-8914-9d42c3db4bef"> After: <img width="1292" alt="image" src="https://github.com/user-attachments/assets/5ee59747-a34f-4dd6-b943-cb5a53d52080"> Pull Request resolved: #137857 Approved by: https://github.com/ezyang, https://github.com/jansel, https://github.com/masnesral ghstack dependencies: #137768

Refactored debug_extra to be on ChoiceCaller (and called description)

6a52f42

[ghstack-poisoned]

Chillee mentioned this pull request Oct 13, 2024

Port Inductor dataclasses to be kw_only #137768

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels Oct 13, 2024

Chillee mentioned this pull request Oct 13, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

Closed

github-actions bot requested a review from ezyang October 13, 2024 09:50

Chillee requested review from eellison, jansel and masnesral and removed request for ezyang October 13, 2024 09:50

Chillee mentioned this pull request Oct 13, 2024

Moved some of Inductor IR nodes to be frozen #137859

Closed

Chillee added 2 commits October 13, 2024 03:56

Chillee mentioned this pull request Oct 13, 2024

Turned Views, Layouts, and Loops into proper dataclasses #137861

Closed

ezyang approved these changes Oct 13, 2024

View reviewed changes

Chillee added the topic: not user facing topic category label Oct 13, 2024

jansel approved these changes Oct 13, 2024

View reviewed changes

masnesral approved these changes Oct 13, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2024

pytorchmergebot added the merging label Oct 13, 2024

pytorchmergebot removed the merging label Oct 13, 2024

pytorchmergebot added the merging label Oct 14, 2024

pytorchmergebot removed the merging label Oct 14, 2024

Chillee added 2 commits October 14, 2024 00:11

pytorchmergebot added the merging label Oct 14, 2024

pytorchmergebot closed this in 1cf78bb Oct 15, 2024

pytorchmergebot added Merged and removed merging labels Oct 15, 2024

github-actions bot deleted the gh/chillee/365/head branch November 15, 2024 02:09

Refactored debug_extra to be on ChoiceCaller (and called description) #137857

Refactored debug_extra to be on ChoiceCaller (and called description) #137857

Uh oh!

Conversation

Chillee commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137857

✅ No Failures

Uh oh!

ezyang Oct 13, 2024

Choose a reason for hiding this comment

Uh oh!

Chillee Oct 13, 2024

Choose a reason for hiding this comment

Uh oh!

Chillee commented Oct 13, 2024

Uh oh!

pytorchmergebot commented Oct 13, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 13, 2024

Merge failed

Uh oh!

Chillee commented Oct 14, 2024

Uh oh!

pytorchmergebot commented Oct 14, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 14, 2024

Merge failed

Uh oh!

Chillee commented Oct 14, 2024

Uh oh!

pytorchmergebot commented Oct 14, 2024

Merge started

Uh oh!

Chillee commented Oct 15, 2024

Uh oh!

pytorchmergebot commented Oct 15, 2024

Uh oh!

pytorchmergebot commented Oct 15, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Chillee commented Oct 13, 2024 •

edited

Loading

pytorch-bot bot commented Oct 13, 2024 •

edited

Loading