Skip to content

Default to use training IR #137804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yushangdi wants to merge 1 commit into from
Closed

Default to use training IR #137804

yushangdi wants to merge 1 commit into from

Conversation

@yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Oct 11, 2024

Summary: Since capture_pre_autograd_graph is deprecated and will be deleted soon, we default this option to true.

Test Plan: CI

Reviewed By: tugsbayasgalan

Differential Revision: D64254236

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137804

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ddda57d with merge base 3e0b83a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yushangdi @facebook-github-bot
Default to use training IR
ddda57d 
Summary: Since capture_pre_autograd_graph is deprecated and will be deleted soon, we default this option to true.

Test Plan: CI

Reviewed By: tugsbayasgalan

Differential Revision: D64254236
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 11, 2024

This pull request was exported from Phabricator. Differential Revision: D64254236

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 11, 2024

This pull request was exported from Phabricator. Differential Revision: D64254236

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 11, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jackzhxng pushed a commit that referenced this pull request Oct 16, 2024
@yushangdi @jackzhxng
Default to use training IR (#137804)
b5e3926 
Summary: Since capture_pre_autograd_graph is deprecated and will be deleted soon, we default this option to true.

Test Plan: CI

Reviewed By: tugsbayasgalan

Differential Revision: D64254236

Pull Request resolved: #137804
Approved by: https://github.com/tugsbayasgalan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tugsbayasgalan tugsbayasgalan tugsbayasgalan approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: AO frontend release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yushangdi @facebook-github-bot @pytorchmergebot @tugsbayasgalan