Do not compute base in export mode #137760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137760
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed19660 with merge base f8a5b71 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
laithsakka
changed the title
[ghstack-poisoned]
[ghstack-poisoned]
zou3519
approved these changes
Oct 15, 2024
bdhirsh
reviewed
Oct 15, 2024
|
|
||
| if ( | ||
| torch.is_inference_mode_enabled() | ||
| not mode.export |
Contributor
There was a problem hiding this comment.
maybe worth a quick commenting mentioning it's because of a bug, not fundamental?
bdhirsh
approved these changes
Oct 15, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Pull Request resolved: #136685 Approved by: https://github.com/zou3519 ghstack dependencies: #137760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):