[inductor] Add config.triton.force_persistent_reductions_threshold #137755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137755
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc5a45c with merge base 432c3fe ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 11, 2024
Chillee
reviewed
Oct 11, 2024
| threshold *= 16 | ||
|
|
||
| if config.triton.force_persistent_reductions_threshold: | ||
| threshold = config.triton.force_persistent_reductions_threshold |
Collaborator
There was a problem hiding this comment.
Should we rationalize this config with multi_kernel which can also be set to 2 to force persistent reductions?
Contributor
Author
There was a problem hiding this comment.
I wasn't aware of that, I'll use that instead thanks!
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: 5204163 Pull Request resolved: pytorch/pytorch#137755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang