Skip to content

[pipelining] rename prev_/next_stage vars to clarify #137739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 3 commits into from
Closed

[pipelining] rename prev_/next_stage vars to clarify #137739

wconstab wants to merge 3 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Oct 10, 2024 •
edited
Loading

@wconstab
Update
90f298d 
[ghstack-poisoned]
This was referenced Oct 10, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137739

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 2576a81 with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 10, 2024
@wconstab wconstab added the topic: not user facing topic category label Oct 10, 2024
@wconstab
Update
e52da02 
[ghstack-poisoned]
wconstab added a commit that referenced this pull request Oct 10, 2024
@wconstab
[pipelining] rename prev_/next_stage vars to clarify
0771e49 
ghstack-source-id: 4cc8dd8
Pull Request resolved: #137739
@wconstab
Update
2576a81 
[ghstack-poisoned]
wconstab added a commit that referenced this pull request Oct 11, 2024
@wconstab
[pipelining] rename prev_/next_stage vars to clarify
99ccaae 
ghstack-source-id: 1051520
Pull Request resolved: #137739
H-Huang
H-Huang approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wconstab
Copy link
Contributor Author

wconstab commented Oct 14, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 14, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 14, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@wconstab
Copy link
Contributor Author

wconstab commented Oct 14, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 14, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/wconstab/341/head branch November 14, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H-Huang H-Huang H-Huang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wconstab @pytorchmergebot @H-Huang