Skip to content

[ONNX] Use torch_2_6 apis from onnxscript #137666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby wants to merge 2 commits into from
Closed

[ONNX] Use torch_2_6 apis from onnxscript #137666

justinchuby wants to merge 2 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 9, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Create an optimize=False option in torch.onnx.export for model optimization

@justinchuby
Update
3b02d8c 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137666

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f05a01b with merge base 7408742 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 9, 2024
@justinchuby justinchuby mentioned this pull request Oct 9, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Oct 9, 2024
@justinchuby
[ONNX] Use torch_2_6 apis from onnxscript
1e7a452 
ghstack-source-id: 54f663c
Pull Request resolved: pytorch#137666
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category labels Oct 9, 2024
@justinchuby
Copy link
Collaborator Author

justinchuby commented Oct 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@justinchuby
Copy link
Collaborator Author

justinchuby commented Oct 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

justinchuby commented Oct 10, 2024

@pytorchbot merge -f "some unrelated workflow stuck"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Oct 10, 2024
@justinchuby @pytorchmergebot
[ONNX] Create an optimize method in ONNXProgram (#137667)
c37bb49 
Move optimization from the export call to the `optimize()` method in ONNXProgram.

Users can call `optimize()` before calling `save()` to save the model. Right now if users set `optimize=True` in `torch.onnx.export` it will have the same effect as calling `optimize()`, but in the future we can evolve the method to be more flexible (e.g. target aware etc.)

Example

```python
onnx_program = torch.onnx.export(..., dynamo=True)
onnx_program.optimize()
onnx_program.save("model.onnx")
```

Pull Request resolved: #137667
Approved by: https://github.com/titaiwangms
ghstack dependencies: #137666
jackzhxng pushed a commit that referenced this pull request Oct 16, 2024
@justinchuby @jackzhxng
[ONNX] Use torch_2_6 apis from onnxscript (#137666)
9e78a18 
Create an `optimize=False` option in `torch.onnx.export` for model optimization

Pull Request resolved: #137666
Approved by: https://github.com/titaiwangms
jackzhxng pushed a commit that referenced this pull request Oct 16, 2024
@justinchuby @jackzhxng
[ONNX] Create an optimize method in ONNXProgram (#137667)
44d717a 
Move optimization from the export call to the `optimize()` method in ONNXProgram.

Users can call `optimize()` before calling `save()` to save the model. Right now if users set `optimize=True` in `torch.onnx.export` it will have the same effect as calling `optimize()`, but in the future we can evolve the method to be more flexible (e.g. target aware etc.)

Example

```python
onnx_program = torch.onnx.export(..., dynamo=True)
onnx_program.optimize()
onnx_program.save("model.onnx")
```

Pull Request resolved: #137667
Approved by: https://github.com/titaiwangms
ghstack dependencies: #137666
@github-actions github-actions bot deleted the gh/justinchuby/106/head branch November 10, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @titaiwangms @pytorchbot