Masked select decomposition #137662
Closed
Masked select decomposition #137662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137662
Note: Links to docs will display an error until the docs builds have been completed. ❌ 56 New FailuresAs of commit 6a2f1e1 with merge base 5516ac5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jackzhxng
force-pushed
the
jz/masked-select-decomp
branch
from
8db387a to
cf4c30b
Compare
jackzhxng
force-pushed
the
jz/masked-select-decomp
branch
from
cf4c30b to
1970077
Compare
Contributor
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
force-pushed
the
jz/masked-select-decomp
branch
from
72c9501 to
a48513d
Compare
Contributor
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
I think this is ok |
larryliu0820
approved these changes
Oct 14, 2024
jackzhxng
requested review from
EikanWang,
aaronenyeshi,
andrewkho,
angelayi,
avikchaudhuri,
divyanshk,
egienvalue,
eqy,
gujinghui,
jeffdaily,
jithunnair-amd,
sraikund16,
syed-ahmed,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
Contributor
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Chillee
requested changes
Oct 17, 2024
| return torch.where(masked_rows, zeros, out) | ||
|
|
||
|
|
||
| @register_decomposition(aten.masked_select) |
Collaborator
There was a problem hiding this comment.
Are there any tests for this?
Contributor
Author
There was a problem hiding this comment.
I don't think so, would you be able to point me to where the decomp tests are? I can try adding one
angelayi
approved these changes
Oct 17, 2024
Contributor
angelayi
left a comment
angelayi
left a comment
There was a problem hiding this comment.
Looks good to me! It pretty much matches the meta kernel too.
jackzhxng
removed
oncall: distributed
Contributor
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
force-pushed
the
jz/masked-select-decomp
branch
from
fb05c51 to
e9fbc02
Compare
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed since ExecuTorch has no portable kernel for
aten.masked_select.