[AOTI] Handle inplace output in ProxyExecutor #137660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: #137401 didn't fix the underlying inplace output issue. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4431312 with merge base f69bf00 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
chenyang78
approved these changes
Oct 10, 2024
Contributor
Author
investigating |
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, lf.linux.g5.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge -f "test_cuda_load is flaky" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 11, 2024
This reverts commit 573101a. Reverted #137660 on behalf of https://github.com/desertfire due to Fails in fbcode ([comment](#137660 (comment)))
Collaborator
|
@desertfire your PR has been successfully reverted. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Summary: Reland #137660 after fixing an internal test failure. Test Plan: CI Differential Revision: D64273204
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 12, 2024
Summary: Reland #137660 after fixing an internal test failure. Test Plan: CI Differential Revision: D64273204
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
Summary: Reland #137660 after fixing an internal test failure. Test Plan: CI Reviewed By: chenyang78 Differential Revision: D64273204
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2024
Summary: Make AOTI generate ABI-compatible code as default for OSS. Pull Request resolved: #136534 Approved by: https://github.com/chenyang78 ghstack dependencies: #137660
KnAwnime
pushed a commit
to KnAwnime/Byblioteka
that referenced
this pull request
Oct 16, 2024
Summary: pytorch/pytorch#137401 didn't fix the underlying inplace output issue. ghstack-source-id: 93cc076 Pull Request resolved: pytorch/pytorch#137660
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: Refine #137660 to support fallback op without a return value. Differential Revision: D66939108
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: Refine #137660 to support fallback op without a return value. Differential Revision: D66939108 Pull Request resolved: #142339 Approved by: https://github.com/henrylhtsang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: #137401 didn't fix the underlying inplace output issue.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang