Skip to content

Update batchnorm expect files #13766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bddppq wants to merge 1 commit into from
Closed

Update batchnorm expect files #13766

bddppq wants to merge 1 commit into from

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Nov 9, 2018

This fixes master breakage introduced in #12325

@soumith @colesbury @Kaixhin

@bddppq
Update batchnorm expect files
d9efe96 
This fixes master breakage introduced in pytorch#12325
facebook-github-bot
facebook-github-bot reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yinghai
Copy link
Contributor

yinghai commented Nov 9, 2018

Still failing?

@bddppq
Copy link
Contributor Author

bddppq commented Nov 9, 2018

There are numerical difference:
densenet:

Nov 09 08:03:21 E               Not equal to tolerance rtol=0.01, atol=1e-07
Nov 09 08:03:21 E               
Nov 09 08:03:21 E               (mismatch 0.05%)
Nov 09 08:03:21 E                x: array([ 0.113393,  0.526646, -0.528282, ...,  0.604505, -0.702039,
Nov 09 08:03:21 E                       0.06567 ], dtype=float32)
Nov 09 08:03:21 E                y: array([ 0.113393,  0.526645, -0.528282, ...,  0.604505, -0.702039,
Nov 09 08:03:21 E                       0.06567 ], dtype=float32)

resnet:

Nov 09 08:03:21 E               Not equal to tolerance rtol=0.001, atol=1e-06
Nov 09 08:03:21 E               
Nov 09 08:03:21 E               (mismatch 0.05%)
Nov 09 08:03:21 E                x: array([-2.312549, -0.695072, -0.268103, ..., -1.373303, -1.301332,
Nov 09 08:03:21 E                       2.290046], dtype=float32)
Nov 09 08:03:21 E                y: array([-2.312549, -0.695071, -0.268103, ..., -1.373307, -1.301334,
Nov 09 08:03:21 E                       2.290045], dtype=float32)

To unbreak master let's revert the original diff.

@bddppq bddppq closed this Nov 9, 2018
@bddppq bddppq deleted the update-batchnorm-expect branch November 9, 2018 09:06
@Kaixhin
Copy link
Contributor

Kaixhin commented Nov 9, 2018

What's going on here? Reverting the initialisation re-opens #12259 .

@yinghai
Copy link
Contributor

yinghai commented Nov 9, 2018

Yeah, unfortunately we prioritize to keep master health. Please resubmit the PR and make sure it doesn't break master test.

@Kaixhin Kaixhin mentioned this pull request Nov 9, 2018
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2019
@Kaixhin @facebook-github-bot
Fix batch norm multiplier init (#13774)
c604658 
Summary:
Fixes #12259, needs to make sure tests (see #13766) don't break due to numerical precision issues. Not sure what would need to be adjusted here...
Pull Request resolved: #13774

Differential Revision: D15715021

Pulled By: ezyang

fbshipit-source-id: 20ce2beee1b39ebe9f023c5f2b25be53acccb5f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

@yinghai yinghai Awaiting requested review from yinghai

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bddppq @yinghai @Kaixhin @facebook-github-bot @houseroad