[BE][MPS] Use Tensor->TensorBase in OperationUtils.h
#137647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137647
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aff526d with merge base de4c2a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
This was referenced Oct 9, 2024
[ghstack-poisoned]
[ghstack-poisoned]
malfet
changed the title
TensorBase rather than Tensor for OpUtils.hTensor->TensorBase in OperationUtils.h
As for the most part those helper method need access to only base class methods [ghstack-poisoned]
As for the most part those helper method need access to only base class methods [ghstack-poisoned]
Skylion007
approved these changes
Oct 10, 2024
Contributor
Author
|
@pytorchbot merge -f "MPS + Lint are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Requested in #77764 (comment) Copy-n-paste kernel implementation from https://github.com/pytorch/pytorch/blob/13cf8360d87306ab3242e827eb662682cff17a19/aten/src/ATen/native/cuda/TensorFactories.cu#L92 though use `float` instead of `double` for square root computation Pull Request resolved: #137648 Approved by: https://github.com/Skylion007, https://github.com/albanD ghstack dependencies: #137601, #137647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
tri[lu]_indices#137648Tensor->TensorBasein OperationUtils.h #137647As for the most part those helper method need access to only base class methods.
Also replace spurious
at::namespace prefixes, i.e.at::Tensor->Tensor