Skip to content

Add support for div in tensorify_python_scalars fx pass #137623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 8 commits into from
Closed

Add support for div in tensorify_python_scalars fx pass #137623

bobrenjc93 wants to merge 8 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Oct 9, 2024 •
edited
Loading

This was referenced Oct 9, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137623

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 7568d06 with merge base 47bb494 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bobrenjc93 bobrenjc93 mentioned this pull request Oct 9, 2024
Closed
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Closed
Closed
Closed
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Oct 9, 2024
@bobrenjc93 bobrenjc93 requested a review from ezyang October 10, 2024 00:23
@bobrenjc93 bobrenjc93 marked this pull request as ready for review October 10, 2024 00:23
@bobrenjc93 bobrenjc93 mentioned this pull request Oct 11, 2024
Closed
ezyang
ezyang approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will comment that the tests are very duplicatey, try to figure out a way to copy paste less.

@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
57add50 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
1de9901 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 13, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 13, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 13, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
57e27ea 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
5b66b49 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
9017aa9 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Update on "Add support for div in tensorify_python_scalars fx pass"
7568d06 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 14, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 14, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 15, 2024

@pytorchbot merge -f "ci failures unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/bobrenjc93/60/head branch November 14, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: fx release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobrenjc93 @pytorchmergebot @ezyang