[WIP] Clean up accelerator APIs #137493

guangyey · 2024-10-08T15:53:02Z

Stack from ghstack (oldest at bottom):

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

pytorch-bot · 2024-10-08T15:53:06Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137493

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 6 Unrelated Failures

As of commit d242dec with merge base cf538ef ():

NEW FAILURES - The following jobs have failed:

inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
inductor / unit-test / cuda12.4-py3.12-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
inductor / unit-test / cuda12.4-py3.13-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
inductor-rocm / rocm6.2-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/distributed/distributed_c10d.py:
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_fsdp_dup_tensors_same_source
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/fsdp/test_wrap.py::TestFSDPWrap::test_bn_always_wrapped_individually
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/fsdp/test_fsdp_misc.py::TestFSDPMiscMultiProcess::test_cpu_init_with_sync_module_states

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 5, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'
pull / linux-focal-py3.13-clang10 / test (default, 3, 5, lf.linux.4xlarge) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'
pull / linux-focal-py3.9-clang10 / test (default, 2, 5, lf.linux.4xlarge) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, lf.linux.4xlarge) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'
pull / linux-jammy-py3.9-gcc11 / test (default, 1, 5, lf.linux.2xlarge) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_autograd_cpp_node_saved_float'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 7df915c Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: d911721 Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: 239afd5 Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: 239afd5 Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: 8a93823 Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: 63fdbdd Pull Request resolved: #137493

[ghstack-poisoned]

ghstack-source-id: 192a121 Pull Request resolved: #137493

[ghstack-poisoned]

github-actions · 2025-02-15T09:34:16Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

guangyey mentioned this pull request Oct 8, 2024

Introduce a device-agnostic runtime API design #132204

Closed

pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Oct 8, 2024

guangyey mentioned this pull request Oct 8, 2024

[RELAND] Add UTs for accelerator device-agnostic runtime APIs #133572

Closed

guangyey changed the title ~~clean up accelerator api~~ [WIP] Clean up accelerator api Oct 8, 2024

guangyey changed the title ~~[WIP] Clean up accelerator api~~ [WIP] Clean up accelerator APIs Oct 8, 2024

pytorchbot added the open source label Oct 8, 2024

Update

83f440a

[ghstack-poisoned]

guangyey added a commit that referenced this pull request Oct 9, 2024

clean up accelerator api

d733956

ghstack-source-id: 7df915c Pull Request resolved: #137493

Update

d8f53e1

[ghstack-poisoned]

guangyey added a commit that referenced this pull request Oct 9, 2024

clean up accelerator api

61523b8

ghstack-source-id: d911721 Pull Request resolved: #137493

Update

7e796ee

[ghstack-poisoned]

guangyey added 2 commits October 9, 2024 18:49

Update

6518c7d

[ghstack-poisoned]

Update

191edcf

[ghstack-poisoned]

guangyey added a commit that referenced this pull request Oct 10, 2024

clean up accelerator api

81653bd

ghstack-source-id: 239afd5 Pull Request resolved: #137493

Update

1a91c31

[ghstack-poisoned]

guangyey changed the title ~~[WIP] Clean up accelerator APIs~~ Clean up accelerator APIs Oct 11, 2024

guangyey requested review from EikanWang, albanD and gujinghui October 11, 2024 05:27

guangyey added a commit that referenced this pull request Oct 14, 2024

clean up accelerator api

dc61290

ghstack-source-id: 239afd5 Pull Request resolved: #137493

guangyey mentioned this pull request Oct 14, 2024

[WIP] Refactor distributed code via device-agnostic API #132371

Closed

EikanWang approved these changes Oct 15, 2024

View reviewed changes

guangyey added 2 commits December 12, 2024 09:46

Update

d6fa94e

[ghstack-poisoned]

Update

c1b8c86

[ghstack-poisoned]

This was referenced Dec 13, 2024

[MPS] Support torch.accelerator.synchronize() on mps #143170

Closed

[MPS] Support torch.accelerator.synchronize() on mps #143171

Closed

guangyey added a commit that referenced this pull request Dec 13, 2024

clean up accelerator api

fdf03e2

ghstack-source-id: 8a93823 Pull Request resolved: #137493

guangyey added 4 commits December 13, 2024 10:48

Update

471e601

[ghstack-poisoned]

Update

861287b

[ghstack-poisoned]

Update

6813b67

[ghstack-poisoned]

Update

719c75c

[ghstack-poisoned]

guangyey added a commit that referenced this pull request Dec 13, 2024

clean up accelerator api

bdd8ec0

ghstack-source-id: 63fdbdd Pull Request resolved: #137493

guangyey added 5 commits December 13, 2024 18:19

Update

5407431

[ghstack-poisoned]

Update

3e50302

[ghstack-poisoned]

Update

b6d9d31

[ghstack-poisoned]

Update

9dd771b

[ghstack-poisoned]

Update

486bd24

[ghstack-poisoned]

guangyey added a commit that referenced this pull request Dec 17, 2024

clean up accelerator api

d145578

ghstack-source-id: 192a121 Pull Request resolved: #137493

Update

d242dec

[ghstack-poisoned]

github-actions bot added the Stale label Feb 15, 2025

guangyey closed this Feb 17, 2025

github-actions bot deleted the gh/guangyey/71/head branch March 23, 2025 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Clean up accelerator APIs #137493

[WIP] Clean up accelerator APIs #137493

Uh oh!

guangyey commented Oct 8, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 8, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[WIP] Clean up accelerator APIs #137493

[WIP] Clean up accelerator APIs #137493

Uh oh!

Conversation

guangyey commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137493

❌ 9 New Failures, 6 Unrelated Failures

Uh oh!

github-actions bot commented Feb 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

guangyey commented Oct 8, 2024 •

edited

Loading

pytorch-bot bot commented Oct 8, 2024 •

edited

Loading