Skip to content

fix bug for fill_empty_deterministic_ not support complex half #137488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wenqiny wants to merge 2 commits into from
Closed

fix bug for fill_empty_deterministic_ not support complex half #137488

wenqiny wants to merge 2 commits into from

Conversation

@wenqiny
Copy link
Contributor

@wenqiny wenqiny commented Oct 8, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137488

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ebcd511 with merge base 76dca1f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@wenqiny wenqiny mentioned this pull request Oct 8, 2024
Closed
Skylion007
Skylion007 reviewed Oct 8, 2024
View reviewed changes
aten/src/ATen/native/TensorFactories.h
tensor.scalar_type(), "fill_empty_deterministic_", AT_WRAP([&]() {
tensor.fill_(std::numeric_limits<scalar_t>::quiet_NaN());
}), AT_EXPAND(AT_FLOATING_TYPES), AT_EXPAND(AT_COMPLEX_TYPES), AT_EXPAND(AT_FLOAT8_TYPES), kBFloat16, kHalf);
}), AT_EXPAND(AT_FLOATING_TYPES), AT_EXPAND(AT_COMPLEX_TYPES), AT_EXPAND(AT_FLOAT8_TYPES), kBFloat16, kHalf, kComplexHalf);
Copy link
Collaborator

@Skylion007 Skylion007 Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The complication here is I am not sure if kComplexHalf is supported on CPU... Let's find out.

Copy link
Contributor Author

@wenqiny wenqiny Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I tried it in my local, but I didn't check the code details that how complex works on CPU.

@Skylion007 Skylion007 added module: cpp Related to C++ API release notes: python_frontend python frontend release notes category labels Oct 8, 2024
@Skylion007
Copy link
Collaborator

Skylion007 commented Oct 8, 2024

@ywq880611 Please fix the lint

@wenqiny
Copy link
Contributor Author

wenqiny commented Oct 9, 2024

lint fixed, PTAL, thanks!

BTW, it seems lintrunner just check for some rules, but it didn't fix the code that violate these rules, we should modify code by ourselves, right?

@ezyang
Copy link
Contributor

ezyang commented Oct 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpp Related to C++ API open source release notes: python_frontend python frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RuntimeError: "fill_empty_deterministic_" not implemented for 'ComplexHalf'

5 participants

@wenqiny @Skylion007 @ezyang @pytorchmergebot @pytorchbot