Skip to content

update get start xpu #137479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZhaoqiongZ wants to merge 5 commits into from
Closed

update get start xpu #137479

ZhaoqiongZ wants to merge 5 commits into from

Conversation

@ZhaoqiongZ
Copy link
Collaborator

@ZhaoqiongZ ZhaoqiongZ commented Oct 8, 2024 •
edited by EikanWang
Loading

  1. respect the comment from the community, downgrade the "Beta" to "Prototype" for the first xpu release with wheel
  2. add wheels installation of torchaudio & torchvision for nightly on Windows

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137479

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a9dcfd9 with merge base 4e30989 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ZhaoqiongZ
Copy link
Collaborator Author

ZhaoqiongZ commented Oct 8, 2024

@pytorchbot label "release notes: xpu"

@pytorch-bot pytorch-bot bot added the release notes: xpu release notes category label Oct 8, 2024
@ZhaoqiongZ
Copy link
Collaborator Author

ZhaoqiongZ commented Oct 8, 2024

Hi @malfet , please help review this update!

@EikanWang EikanWang requested a review from seemethere October 8, 2024 06:28
@jingxu10 jingxu10 mentioned this pull request Oct 10, 2024
Closed
@soulitzer soulitzer requested a review from malfet October 10, 2024 15:08
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 10, 2024
atalman
atalman approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kit1980
kit1980 reviewed Oct 16, 2024
View reviewed changes
docs/source/notes/get_start_xpu.rst
.. code-block::
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/xpu
pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/xpu
Copy link
Contributor

@kit1980 kit1980 Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want torchaudio here?

Copy link
Contributor

@atalman atalman Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we do have both torchaudio and torchvision xpu builds: https://hud2.pytorch.org/hud/pytorch/audio/nightly/1?per_page=50&name_filter=xpu

@malfet
Copy link
Contributor

malfet commented Oct 16, 2024

@pytorchbot merge -f "Docs only change"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980
Copy link
Contributor

kit1980 commented Oct 16, 2024

@pytorchbot cherry-pick

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@pytorch pytorch deleted a comment from pytorchbot Oct 16, 2024
@kit1980
Copy link
Contributor

kit1980 commented Oct 16, 2024

@pytorchbot cherry-pick --onto release/2.5 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 16, 2024
@ZhaoqiongZ @pytorchbot
update get start xpu (#137479)
f27d765 
1. respect the comment from the community, downgrade the "Beta" to "Prototype" for the first xpu release with wheel
2. add wheels installation of torchaudio & torchvision for nightly on Windows
Pull Request resolved: #137479
Approved by: https://github.com/atalman, https://github.com/malfet

(cherry picked from commit 7ba706c)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 16, 2024

Cherry picking #137479

The cherry pick PR is at #138090 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 16, 2024
Closed
kit1980 pushed a commit that referenced this pull request Oct 18, 2024
@pytorchbot @ZhaoqiongZ
update getting started xpu (#138090)
a97c151 
update get start xpu (#137479)

1. respect the comment from the community, downgrade the "Beta" to "Prototype" for the first xpu release with wheel
2. add wheels installation of torchaudio & torchvision for nightly on Windows
Pull Request resolved: #137479
Approved by: https://github.com/atalman, https://github.com/malfet

(cherry picked from commit 7ba706c)

Co-authored-by: Zheng, Zhaoqiong <[email protected]>
@ZhaoqiongZ ZhaoqiongZ mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@malfet malfet malfet approved these changes

@seemethere seemethere Awaiting requested review from seemethere

+1 more reviewer

@kit1980 kit1980 kit1980 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source release notes: xpu release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZhaoqiongZ @malfet @pytorchmergebot @kit1980 @pytorchbot @atalman @soulitzer