-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[SymmetricMemoryOps] implement two-shot all-reduce #137473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137473
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f90ee56 with merge base 9b2e453 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
This StackImplement custom all-reduce algos available in This PRImplement |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…reduce (#137474) ## This Stack Implement custom all-reduce algos available in `IntraNodeComm` as `symm_mem` ops and replace the existing `IntraNodeComm` kernels with them. ## This PR Implement `symm_mem::multimem_one_shot_all_reduce_out`. The out-variant is more suitable for `IntraNodeComm` integration. Pull Request resolved: #137474 Approved by: https://github.com/Chillee ghstack dependencies: #137471, #137472, #137473
…m ops (#137475) ## This Stack Implement custom all-reduce algos available in `IntraNodeComm` as `symm_mem` ops and replace the existing `IntraNodeComm` kernels with them. ## This PR - Replaces one-shot all-reduce with `symm_mem::one_shot_all_reduce_out` - Replaces two-shot all-reduce with `symm_mem::two_shot_all_reduce_` - Removes HCM all-reduce (at least for now). Due to the nature of its accumulation order, we can't guarantee the numerical consistency across all ranks. - Removes the `IntraNodeComm` python binding (its original purpose is superceded by `SymmetricMemory`). - Removes methods that were made for the python binding. - Replaces nvlink detection logic with `DMAConnectivityDetector`. Pull Request resolved: #137475 Approved by: https://github.com/Chillee ghstack dependencies: #137471, #137472, #137473, #137474
…ating bfloat16 with multimem.ld_reduce (#137529) This provides better accuracy without additional cost. Also added documentation to `multimem_one_shot_all_reduce` to note the numerical caveats. Pull Request resolved: #137529 Approved by: https://github.com/Chillee ghstack dependencies: #137471, #137472, #137473, #137474, #137475
- Previously the detection would fail before user calling APIs such as `torch.cuda.set_device()`. This is because the detection logic requires nvml initialization. In this PR, we added explicit nvml initialization (which idempotent). - Previously any nvml issue occurred in the detection logic would result in fatal error. Now we issue an informative warning and return a topology assuming no NVLink connectivity. Pull Request resolved: #137530 Approved by: https://github.com/Chillee ghstack dependencies: #137471, #137472, #137473, #137474, #137475, #137529
ghstack-source-id: 3e66c10 Pull Request resolved: pytorch/pytorch#137473
Stack from ghstack (oldest at bottom):
This Stack
Implement custom all-reduce algos available in
IntraNodeCommassymm_memops and replace the existingIntraNodeCommkernels with them.This PR
Implement
symm_mem::two_shot_all_reduce_. Later we'll replace the two-shot all-reduce inIntraNodeCommwith these.cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o