[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

Chillee · 2024-10-06T19:45:24Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

…ong for cutlass [ghstack-poisoned]

pytorch-bot · 2024-10-06T19:45:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137410

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 58c8acc with merge base 8fbf866 ():

NEW FAILURES - The following jobs have failed:

Check Labels / Check labels (gh)
# This PR needs a release notes: label
Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/_inductor/runtime/hints.py:
pull / cuda12.1-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh)
REGRESSION: benchmark ('basic_modules_ListOfLinears_inductor_gpu', 'compile_time_instruction_count') failed, actual result 23672334106 is 44.32% higher than expected 16403080126 ±+20.00% if this is an expected regression, please update the expected results.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_cutlass_backend.py::TestCutlassBackend::test_max_autotune_cutlass_backend_addmm_dynamic_False_max_autotune_gemm_backends_CUTLASS
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.11-clang10 / test (default, 2, 4, linux.4xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.12-clang10 / test (default, 2, 4, linux.4xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 2, 3, linux.4xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.9-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-focal-py3.9-clang10 / test (default, 2, 4, linux.4xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported
pull / linux-jammy-py3.9-gcc11 / test (default, 2, 4, linux.2xlarge) (gh)
test_public_bindings.py::TestPublicBindings::test_modules_can_be_imported

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ong for cutlass ghstack-source-id: e9b174e Pull Request resolved: #137410

github-actions · 2024-10-06T19:47:11Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…abled ping-ong for cutlass" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

…ong for cutlass ghstack-source-id: cd569ce Pull Request resolved: #137410

…abled ping-ong for cutlass" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

…ong for cutlass ghstack-source-id: 8abbb70 Pull Request resolved: #137410

…abled ping-ong for cutlass" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

…ong for cutlass ghstack-source-id: 86479bb Pull Request resolved: #137410

…abled ping-ong for cutlass" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

github-actions · 2024-12-24T19:33:56Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-…

2bdd603

…ong for cutlass [ghstack-poisoned]

Chillee added a commit that referenced this pull request Oct 6, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-…

100a2bd

…ong for cutlass ghstack-source-id: e9b174e Pull Request resolved: #137410

pytorch-bot bot added ciflow/inductor module: inductor labels Oct 6, 2024

github-actions bot requested a review from ezyang October 6, 2024 19:45

Chillee mentioned this pull request Oct 11, 2024

Port Inductor dataclasses to be kw_only #137768

Closed

Chillee added a commit that referenced this pull request Oct 11, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-…

f5f9f23

…ong for cutlass ghstack-source-id: cd569ce Pull Request resolved: #137410

Chillee added 2 commits October 11, 2024 15:20

Chillee mentioned this pull request Oct 13, 2024

Refactored debug_extra to be on ChoiceCaller (and called description) #137857

Closed

Chillee mentioned this pull request Oct 13, 2024

Moved some of Inductor IR nodes to be frozen #137859

Closed

Chillee mentioned this pull request Oct 13, 2024

Turned Views, Layouts, and Loops into proper dataclasses #137861

Closed

Chillee added a commit that referenced this pull request Oct 16, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-…

7c253d2

…ong for cutlass ghstack-source-id: 8abbb70 Pull Request resolved: #137410

Chillee added a commit that referenced this pull request Oct 17, 2024

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-…

d329f71

…ong for cutlass ghstack-source-id: 86479bb Pull Request resolved: #137410

bertmaher added a commit that referenced this pull request Oct 22, 2024

my local copy of pr #137410

fa00b8c

Chillee mentioned this pull request Oct 23, 2024

Fixed max-autotune in FlexAttention to reset kernel options appropriately #138733

Closed

Chillee added 2 commits October 23, 2024 14:52

This was referenced Oct 24, 2024

Made DDPOptimizer work with HOPs #138787

Closed

Added option to control number of kernel options displayed #138788

Closed

Chillee added 2 commits October 23, 2024 21:42

Chillee mentioned this pull request Oct 24, 2024

Fix free symbol handling in FlexAttention #138794

Closed

Chillee added 3 commits October 23, 2024 22:54

Chillee mentioned this pull request Oct 25, 2024

Stop force realizing to prevent recursion errors unless it's much bigger #138881

Closed

Chillee mentioned this pull request Oct 25, 2024

Add some error messages for flexattention #138891

Closed

github-actions bot added the Stale label Dec 24, 2024

github-actions bot closed this Jan 23, 2025

github-actions bot deleted the gh/chillee/362/head branch February 23, 2025 02:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

Uh oh!

Chillee commented Oct 6, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Oct 6, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 6, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

[WIP] Added swizzle searching, disabled fp16 accum, and enabled ping-ong for cutlass #137410

Uh oh!

Conversation

Chillee commented Oct 6, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137410

❌ 14 New Failures

Uh oh!

github-actions bot commented Oct 6, 2024

This PR needs a release notes: label

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Chillee commented Oct 6, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 6, 2024 •

edited

Loading

This PR needs a `release notes:` label