Fix ir._WaitKernel #137401
Closed
Fix ir._WaitKernel #137401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137401
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 391c985 with merge base 4830bd0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
oncall: distributed
desertfire
approved these changes
Oct 6, 2024
yf225
reviewed
Oct 7, 2024
| @fresh_inductor_cache() | ||
| def test_wait_tensor_temp(self): | ||
| def func(arg: torch.Tensor) -> torch.Tensor: | ||
| return funcol.wait_tensor(arg) |
Contributor
There was a problem hiding this comment.
I believe in the current unit test, arg is a normal torch.Tensor and calling .wait_tensor() on it has unclear semantics. Would it work if we pass an AsyncCollectiveTensor into this function (e.g. passing in the output of funcol.all_reduce(buf0, "avg", "0") from eager mode)?
Contributor
There was a problem hiding this comment.
Discussed offline. I am landing this now to unblock #136534. @benjaminglass1 please follow up on the unit test improvement.
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
desertfire
added a commit
that referenced
this pull request
Oct 9, 2024
Summary: #137401 didn't fix the underlying inplace output issue. [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 9, 2024
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 9, 2024
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 10, 2024
…tor" Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 10, 2024
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 10, 2024
…tor" Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 10, 2024
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Summary: #137401 didn't fix the underlying inplace output issue. Pull Request resolved: #137660 Approved by: https://github.com/chenyang78
desertfire
added a commit
that referenced
this pull request
Oct 13, 2024
…tor" Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 13, 2024
Summary: #137401 didn't fix the underlying inplace output issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2024
Summary: #137401 didn't fix the underlying inplace output issue. Pull Request resolved: #137660 Approved by: https://github.com/chenyang78
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
In ABI-compatible mode, AOTInductor could not compile _WaitKernel due to an incorrect outputs list. Add the correct set of outputs, as done in ir._CollectiveKernel.create_out_of_place. ghstack-source-id: 696daaa Pull Request resolved: pytorch/pytorch#137401
KnAwnime
pushed a commit
to KnAwnime/Byblioteka
that referenced
this pull request
Oct 16, 2024
Summary: pytorch/pytorch#137401 didn't fix the underlying inplace output issue. ghstack-source-id: 93cc076 Pull Request resolved: pytorch/pytorch#137660
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In ABI-compatible mode, AOTInductor could not compile _WaitKernel due to
an incorrect outputs list. Add the correct set of outputs, as done in
ir._CollectiveKernel.create_out_of_place.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang