Skip to content

Search through config changes in compiler bisector #137346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eellison wants to merge 5 commits into from
Closed

Search through config changes in compiler bisector #137346

eellison wants to merge 5 commits into from

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Oct 4, 2024 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Follow up to #131936. In the original bisector you'd have to test inline if we were disabling a component - if BisectionManager.disable_subsystem("inductor", "post_grad_passes", debug_info). This adds a convenient way of testing config changes for root causing issue. I've added emulate_precision_casts and aot_eager_decomp_partition cse as initial ones.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec

@eellison
WIP configs bisect
af41af0 
[ghstack-poisoned]
@eellison eellison mentioned this pull request Oct 4, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137346

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 276fa56 with merge base 1c71de5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Oct 4, 2024
@eellison
WIP configs bisect
da8eab5 
ghstack-source-id: 127ae29
Pull Request resolved: #137346
@eellison
Copy link
Contributor Author

eellison commented Oct 10, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2024

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/eellison/699/orig returned non-zero exit code 1

Rebasing (1/2)
Auto-merging test/run_test.py
Auto-merging torch/__init__.py
Auto-merging torch/_inductor/codecache.py
Auto-merging torch/_inductor/fx_passes/post_grad.py
CONFLICT (content): Merge conflict in torch/_inductor/fx_passes/post_grad.py
Auto-merging torch/_inductor/graph.py
Auto-merging torch/fx/experimental/proxy_tensor.py
error: could not apply 71db3dd941... Add compiler bisector
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Could not apply 71db3dd941... Add compiler bisector

Raised by https://github.com/pytorch/pytorch/actions/runs/11278956496

@eellison
Update on "WIP configs bisect"
043425f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 10, 2024
@eellison
WIP configs bisect
9d045dc 
ghstack-source-id: ff235cd
Pull Request resolved: #137346
@eellison eellison added the topic: not user facing topic category label Oct 10, 2024
@eellison
Update on "WIP configs bisect"
b2e74b5 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
@eellison eellison changed the title WIP configs bisect Bisect through config changes Oct 11, 2024
@eellison eellison changed the title Bisect through config changes Search through config changes Oct 11, 2024
@eellison
Update on "Search through config changes"
48a9504 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 11, 2024
@eellison
Add easy way to enable/disable configs in compiler bisect
e367bbe 
ghstack-source-id: 3c013a2
Pull Request resolved: #137346
@eellison eellison changed the title Search through config changes Search through config changes in compiler bisector Oct 11, 2024
@eellison eellison requested a review from zou3519 October 11, 2024 16:12
@eellison
Copy link
Contributor Author

eellison commented Oct 11, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@eellison
Update
276fa56 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2024

Successfully rebased gh/eellison/699/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/137346)

pytorchmergebot pushed a commit that referenced this pull request Oct 11, 2024
@eellison
Add easy way to enable/disable configs in compiler bisect
65a4405 
ghstack-source-id: fba63fc
Pull Request resolved: #137346
@eellison
Copy link
Contributor Author

eellison commented Oct 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/eellison/699/head branch November 11, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eellison @pytorchmergebot @zou3519