Skip to content

[AOTI] Add C shim for MKLDNN _convolution_pointwise #137269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desertfire wants to merge 4 commits into from
Closed

[AOTI] Add C shim for MKLDNN _convolution_pointwise #137269

desertfire wants to merge 4 commits into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Oct 3, 2024 •
edited
Loading

@desertfire desertfire mentioned this pull request Oct 3, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137269

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 62d59cc with merge base 13ec343 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor labels Oct 3, 2024
@desertfire
Update on "[AOTI] Add C shim for MKLDNN _convolution_pointwise"
3143eb5 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]
@desertfire
Update on "[AOTI] Add C shim for MKLDNN _convolution_pointwise"
b69072b 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Oct 3, 2024
@desertfire
[AOTI] Add C shim for MKLDNN _convolution_pointwise
48143b5 
ghstack-source-id: 11dc737
Pull Request resolved: #137269
@desertfire desertfire added topic: not user facing topic category topic: performance topic category topic: improvements topic category and removed topic: performance topic category topic: not user facing topic category labels Oct 3, 2024
@desertfire
Update on "[AOTI] Add C shim for MKLDNN _convolution_pointwise"
62d59cc 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Oct 4, 2024
@desertfire
[AOTI] Add C shim for MKLDNN _convolution_pointwise
ef503d9 
ghstack-source-id: 613565b
Pull Request resolved: #137269
@desertfire
Copy link
Contributor Author

desertfire commented Oct 4, 2024

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 4, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/desertfire/484/head branch November 6, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hl475 hl475 hl475 approved these changes

@leslie-fang-intel leslie-fang-intel Awaiting requested review from leslie-fang-intel

+1 more reviewer

@chenyang78 chenyang78 chenyang78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor release notes: inductor topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@desertfire @facebook-github-bot @pytorchmergebot @chenyang78 @hl475