Skip to content

[MPS] Add regression test for fft.fftfreq #137215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kit1980 merged 1 commit into from
Oct 2, 2024
Merged

[MPS] Add regression test for fft.fftfreq #137215

kit1980 merged 1 commit into from
Oct 2, 2024

Conversation

@pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Oct 2, 2024

The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

@hvaara @pytorchbot
[MPS] Add regression test for fft.fftfreq (#135440)
894c46b 
The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

Pull Request resolved: #135440
Approved by: https://github.com/ezyang

(cherry picked from commit 09287e3)
This was referenced Oct 2, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137215

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 12 Cancelled Jobs

As of commit 894c46b with merge base b7eb725 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) topic: not user facing topic category labels Oct 2, 2024
@kit1980
Copy link
Contributor

kit1980 commented Oct 2, 2024

I don't understand why "Mac MPS / macos-py3-arm64 / build (push)" fails, going to merge and see if it's failing on trunk.

@kit1980 kit1980 merged commit 783a6a4 into release/2.5 Oct 2, 2024
@github-actions github-actions bot deleted the cherry-pick-135440-by-pytorch_bot_bot_ branch November 6, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pytorchbot @kit1980 @malfet @hvaara