Skip to content

[FlexAttention] Fix max-autotune when captured buffers are View nodes #137204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drisspg wants to merge 1 commit into from
Closed

[FlexAttention] Fix max-autotune when captured buffers are View nodes #137204

drisspg wants to merge 1 commit into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Oct 2, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137204

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit a0f21ee with merge base a00f0d5 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / linux-docs / build-docs-python-false (gh) (trunk failure)
    /opt/conda/envs/py_3.9/lib/python3.9/site-packages/sphinx/util/inspect.py:376: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Oct 2, 2024
@drisspg
[FlexAttention] Fix max-autotune when captured buffers are View nodes
d3b9882 
ghstack-source-id: 3f0586c
Pull Request resolved: #137204
@drisspg drisspg requested review from Chillee and yanboliang and removed request for Chillee October 2, 2024 19:22
@drisspg drisspg added the topic: not user facing topic category label Oct 2, 2024
@drisspg drisspg mentioned this pull request Oct 2, 2024
Open
@drisspg
Copy link
Contributor Author

drisspg commented Oct 2, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100)

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Oct 2, 2024

@pytorchbot merge -I "the existing failures are unrelated"

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -I the existing failures are unrelated

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@drisspg
Copy link
Contributor Author

drisspg commented Oct 2, 2024

@pytorchbot merge -f "The existing failures are unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/drisspg/58/head branch November 6, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@yanboliang yanboliang Awaiting requested review from yanboliang

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drisspg @pytorchmergebot @Chillee @BoyuanFeng