Skip to content

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Oct 2, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137203

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6b79669 with merge base 8c29a0d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Oct 2, 2024
awgu pushed a commit that referenced this pull request Oct 2, 2024
ghstack-source-id: e884184
Pull Request resolved: #137203
@awgu awgu added release notes: distributed (fsdp2) release notes category and removed release notes: distributed (fsdp) release notes category labels Oct 2, 2024
@awgu
Copy link
Collaborator Author

awgu commented Oct 2, 2024

@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cc XilunWu H-Huang kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

Differential Revision: [D63777335](https://our.internmc.facebook.com/intern/diff/D63777335)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Oct 2, 2024
ghstack-source-id: 7f13484
Pull Request resolved: #137203
@awgu
Copy link
Collaborator Author

awgu commented Oct 2, 2024

@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@awgu awgu added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2024
@awgu awgu marked this pull request as ready for review October 11, 2024 16:08
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp to unblock

@awgu
Copy link
Collaborator Author

awgu commented Oct 11, 2024

let us just try to land this for now

@awgu
Copy link
Collaborator Author

awgu commented Oct 11, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp2) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants