Skip to content

[BE] [CI] Skip clean gha workspace if CI is running in a container for checkout-pytorch #137168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeanschmidt wants to merge 2 commits into from
Closed

[BE] [CI] Skip clean gha workspace if CI is running in a container for checkout-pytorch #137168

jeanschmidt wants to merge 2 commits into from

Conversation

@jeanschmidt
Copy link
Contributor

@jeanschmidt jeanschmidt commented Oct 2, 2024 •
edited
Loading

For the reusable action checkout-pytorch, skips cleaning workspace when running from a container environment.

The motivation for this change is twofold:

  • There is no need for cleanup when running in ephemeral containers, as any changes will be discarded when the docker container is terminated;
  • In the specific case of GITHUB_WORKSPACE, to enable sharing this between multiple containers, it need to be mounted with -v. This prevents the possibility of running rm -r and deleting this mount path;

@jeanschmidt jeanschmidt requested a review from a team as a code owner October 2, 2024 09:45
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137168

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit a876154 with merge base 52d29a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 2, 2024
@jeanschmidt jeanschmidt self-assigned this Oct 2, 2024
@jeanschmidt jeanschmidt added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/nightly Trigger all jobs we run nightly (nightly.yml) labels Oct 2, 2024
@jeanschmidt jeanschmidt changed the title Skip clean gha workspace if CI is running in a container for checkout-pytorch [BE] Skip clean gha workspace if CI is running in a container for checkout-pytorch Oct 2, 2024
@jeanschmidt jeanschmidt changed the title [BE] Skip clean gha workspace if CI is running in a container for checkout-pytorch [BE] [CI] Skip clean gha workspace if CI is running in a container for checkout-pytorch Oct 2, 2024
huydhn
huydhn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM code-wise but I am curious why cleaning up the local workspace needs to be skipped here. An explanation on the PR description would be great.

@jeanschmidt
Copy link
Contributor Author

jeanschmidt commented Oct 2, 2024

@pytorchbot merge -f "stuck signals"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the jeanschmidt/disable-clean-workspace-checkout branch November 6, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

@jeanschmidt jeanschmidt

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeanschmidt @pytorchmergebot @huydhn