Skip to content

Conversation

@angelayi
Copy link
Contributor

@angelayi angelayi commented Oct 1, 2024

Stack from ghstack (oldest at bottom):

Refactor so that unflattener doesn't become too messy

Differential Revision: D63719648

Refactor so that unflattener doesn't become too messy

Differential Revision: [D63719648](https://our.internmc.facebook.com/intern/diff/D63719648/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137134

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 01d982b with merge base f2d174c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

angelayi added a commit that referenced this pull request Oct 1, 2024
Refactor so that unflattener doesn't become too messy

Differential Revision: [D63719648](https://our.internmc.facebook.com/intern/diff/D63719648/)

ghstack-source-id: 245757116
Pull Request resolved: #137134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63719648

Copy link
Contributor

@avikchaudhuri avikchaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of being able to import things from torch.export.unflatten? Since it is both a module as well as a function...

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2024
@angelayi
Copy link
Contributor Author

angelayi commented Oct 2, 2024

What's the status of being able to import things from torch.export.unflatten? Since it is both a module as well as a function...

I have no clue.. I don't really know how that works..

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63719648

angelayi added a commit that referenced this pull request Oct 5, 2024
Pull Request resolved: #137134

Refactor so that unflattener doesn't become too messy
ghstack-source-id: 246432900

Differential Revision: [D63719648](https://our.internmc.facebook.com/intern/diff/D63719648/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63719648

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/angelayi/60/head branch November 7, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants