Skip to content

[Inductor] Enable a SDPA pattern matching for CUDA #137085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desertfire wants to merge 2 commits into from
Closed

[Inductor] Enable a SDPA pattern matching for CUDA #137085

desertfire wants to merge 2 commits into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Oct 1, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137085

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e1c1bd0 with merge base 8765804 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire desertfire added the topic: not user facing topic category label Oct 1, 2024
@desertfire desertfire mentioned this pull request Oct 1, 2024
Closed
@desertfire
Copy link
Contributor Author

desertfire commented Oct 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@sanchitintel
Copy link
Collaborator

sanchitintel commented Oct 1, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@desertfire
Update
e1c1bd0 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Successfully rebased gh/desertfire/478/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/137085)

pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@desertfire
[Inductor] Enable a SDPA pattern matching for CUDA
2152a9f 
Summary: Fixes #122429

ghstack-source-id: e288989
Pull Request resolved: #137085
@sanchitintel
Copy link
Collaborator

sanchitintel commented Oct 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100)

Details for Dev Infra team Raised by workflow job

@desertfire
Copy link
Contributor Author

desertfire commented Oct 2, 2024

@pytorchbot merge -f "inductor_torchbench_smoketest_perf is flaky on trunk"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@desertfire @AnantGulati
[Inductor] Enable a SDPA pattern matching for CUDA (pytorch#137085)
b4a9cf1 
Summary: Fixes pytorch#122429

Pull Request resolved: pytorch#137085
Approved by: https://github.com/eellison
@github-actions github-actions bot deleted the gh/desertfire/478/head branch November 6, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@sanchitintel sanchitintel Awaiting requested review from sanchitintel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desertfire @pytorchmergebot @sanchitintel @eellison