Skip to content

[non ghstack] Init threadpool with user defined num_threads before default #137051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 3 commits into from
Closed

[non ghstack] Init threadpool with user defined num_threads before default #137051

janeyx99 wants to merge 3 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Sep 30, 2024 •
edited
Loading

Very similar to #136793, but adds back pool->set_thread_count call as it is still necessary (I am guessing due to the mutex)

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137051

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b8d03bb with merge base ef6fd3d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 30, 2024

@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@janeyx99 janeyx99 added topic: bug fixes topic category release notes: cpp release notes category labels Sep 30, 2024
@janeyx99 janeyx99 changed the title [non ghstack] Init threadpool with user defined num_threads before default for OMP [non ghstack] Init threadpool with user defined num_threads before default Oct 1, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 1, 2024

@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@janeyx99 janeyx99 mentioned this pull request Oct 1, 2024
Closed
albanD
albanD approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@janeyx99
Copy link
Contributor Author

janeyx99 commented Oct 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

janeyx99 commented Oct 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the trying-again branch November 6, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cpp release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @facebook-github-bot @pytorchmergebot @albanD